From: Mark Brown <broonie@kernel.org>
To: Bo Shen <voice.shen@atmel.com>
Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] ASoC: wm8904: switch to CCF
Date: Fri, 06 Jun 2014 09:57:06 +0000 [thread overview]
Message-ID: <20140606095706.GB2520@sirena.org.uk> (raw)
In-Reply-To: <1401963572-10953-3-git-send-email-voice.shen@atmel.com>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Thu, Jun 05, 2014 at 06:19:29PM +0800, Bo Shen wrote:
> + if (wm8904->mclk)
> + clk_prepare_enable(wm8904->mclk);
There's no point in having checks for MCLK here since...
> + wm8904->mclk = devm_clk_get(&i2c->dev, "mclk");
> + if (IS_ERR(wm8904->mclk)) {
> + ret = PTR_ERR(wm8904->mclk);
> + dev_err(&i2c->dev, "Failed to get MCLK\n");
> + return ret;
> + }
...we require a clock here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-06 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 10:19 [PATCH 0/5] ARM: atmel: switch audio to CCF Bo Shen
2014-06-05 10:19 ` [PATCH 1/5] ASoC: atmel_wm8904: switch " Bo Shen
2014-06-06 10:02 ` Mark Brown
2014-06-05 10:19 ` [PATCH 2/5] ASoC: wm8904: " Bo Shen
2014-06-06 9:57 ` Mark Brown [this message]
2014-06-05 10:19 ` [PATCH 3/5] dt: wm8904: add device tree binding document Bo Shen
2014-06-06 9:58 ` Mark Brown
2014-06-05 10:19 ` [PATCH 4/5] ARM: atmel: sama5d3xek: switch sound to CCF Bo Shen
2014-06-06 10:00 ` Mark Brown
2014-06-05 10:19 ` [PATCH 5/5] ARM: atmel: at91sam9n12ek: " Bo Shen
2014-06-06 10:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606095706.GB2520@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox