Re: [PATCH 2/5] ASoC: wm8904: switch to CCF

Mark Brown
2014-06-06T09:57:06Z

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Thu, Jun 05, 2014 at 06:19:29PM +0800, Bo Shen wrote:

> + if (wm8904->mclk)
> + clk_prepare_enable(wm8904->mclk);

There's no point in having checks for MCLK here since...

> + wm8904->mclk = devm_clk_get(&i2c->dev, "mclk");
> + if (IS_ERR(wm8904->mclk)) {
> + ret = PTR_ERR(wm8904->mclk);
> + dev_err(&i2c->dev, "Failed to get MCLK\n");
> + return ret;
> + }

...we require a clock here.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]