From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Dan Murphy <dmurphy@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier
Date: Mon, 30 Jun 2014 21:43:42 +0000 [thread overview]
Message-ID: <20140630214342.GI23300@sirena.org.uk> (raw)
In-Reply-To: <20140630172115.GE28740@leverpostej>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:
> > +Optional properties:
> > +- power-gpio - gpio pin to enable/disable the device
> The code below seems to look for "enable-gpio". Searching for
> "power-gpio" only hits in the line above and the example below. I assume
> the code is in error?
It depends what this is for - if it's for an external regulator it
should be a regulator binding. Also all GPIO properties
are supposed to be called -gpios because DT conventions.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-30 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 17:10 [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier Dan Murphy
2014-06-30 17:21 ` Mark Rutland
2014-06-30 17:27 ` Dan Murphy
2014-06-30 21:43 ` Mark Brown [this message]
2014-07-01 8:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630214342.GI23300@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox