From: Mark Brown <broonie@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: tas2552: Fix PM sequencing
Date: Mon, 21 Jul 2014 12:19:31 +0000 [thread overview]
Message-ID: <20140721121931.GX17528@sirena.org.uk> (raw)
In-Reply-To: <1405704668-8038-1-git-send-email-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
On Fri, Jul 18, 2014 at 12:31:07PM -0500, Dan Murphy wrote:
> In the pm suspend/resume it is better
> to disable the GPIO after the regmap_cache
> setting calls so that if the call is interrupted
> the new reg values will be cached and set on resume.
>
> Also add pm_runtime_put in the remove call.
Applied, thanks, but please don't mix multiple changes into one commit
like this especially when there's no textual overlap.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-21 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 17:31 [PATCH 1/2] ASoC: tas2552: Fix PM sequencing Dan Murphy
2014-07-18 17:31 ` [PATCH 2/2] ASoC: tas2552: Add DAPM calls for amp and PLL Dan Murphy
2014-07-21 11:53 ` Mark Brown
2014-07-25 18:54 ` Murphy, Dan
2014-07-29 18:51 ` Mark Brown
2014-07-21 12:19 ` Mark Brown [this message]
2014-07-21 13:23 ` [PATCH 1/2] ASoC: tas2552: Fix PM sequencing Murphy, Dan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721121931.GX17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox