From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 26 Jan 2015 16:42:29 +0000 Subject: Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table Message-Id: <20150126164229.GB21293@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="ViWwB84N1zFtNiVD" List-Id: References: <1418614273-2303-1-git-send-email-voice.shen@atmel.com> <20150115115425.GX3043@sirena.org.uk> <54B866B9.8000900@atmel.com> <54C65C36.9050106@atmel.com> In-Reply-To: <54C65C36.9050106@atmel.com> To: Nicolas Ferre Cc: Bo Shen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, Alexander Morozov --ViWwB84N1zFtNiVD Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: > Le 16/01/2015 02:17, Bo Shen a =E9crit : > >> Does this end up in the i2c_driver_id driver data or do we need some > >> extra code when devtype is assigned to check for an of_node and look at > >> the DT data instead? That certainly used to be the case... > > At the beginning I think as the same as you, and also add the code to= =20 > > get the data as I do in . However, as I=20 > > remember, I2C seems only use the compatible string after the comma, tha= t=20 > > means only for "wlf,wm8904", it uses "wm8904" to match. So, I remove al= l=20 > > the code I added, and just keep these, and it can get the device type= =20 > > correctly. > > So, when I submit the patch and keep the code as simple as possible. > I don't understand what's keeping this patch from being applied. Voice, > do you mind re-sending? I need to convince myself that the above actually works and is doing the right thing; the above explanation sounds like if it works it might be relying on a bug. --ViWwB84N1zFtNiVD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJUxm50AAoJECTWi3JdVIfQRJkH/26//wf/lSxYQGI3s2tcHMY3 xLGkekFc+GuSLkudf84JTvMwmGuRsh7wGW5OfV40Oq1OB4Fxoj2H9N5ySWv8K/1+ HYlc1gd2AqYKGM/o60VpBIOIQadPaxIVFYVmf0XcBxfjktuAi2lGO/c66D3QskA8 EmHHT4ZbReTWV3TfMB3inIey6mSFgEkszfcOzvU05vwpy5VH7xrpi7JG5gSTXNxG 9Aet8v38l5At0M2Tflb/SqrAKAZtSpxwqTz7IATe4l9W4r3KjOAUH1bRfj7ngFQh unMs+/PJx9sjGXHYw9/Ma8FJyXbJPkQada3aB1WdgRGsXbtxNeZX1PuZ/7M2Jpg= =qC8j -----END PGP SIGNATURE----- --ViWwB84N1zFtNiVD--