From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org, tiwai@suse.com, perex@perex.cz
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
amadeuszx.slawinski@linux.intel.com,
pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v4 09/16] ASoC: codecs: hdac_hda: Switch to new stream-format interface
Date: Thu, 16 Nov 2023 12:22:48 +0100 [thread overview]
Message-ID: <20231116112255.1584795-10-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20231116112255.1584795-1-cezary.rojewski@intel.com>
To provide option for selecting different bit-per-sample than just the
maximum one, use the new format calculation mechanism.
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/codecs/hdac_hda.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/hdac_hda.c b/sound/soc/codecs/hdac_hda.c
index 355f30779a34..c08375672661 100644
--- a/sound/soc/codecs/hdac_hda.c
+++ b/sound/soc/codecs/hdac_hda.c
@@ -215,18 +215,16 @@ static int hdac_hda_dai_hw_params(struct snd_pcm_substream *substream,
struct hdac_hda_priv *hda_pvt;
unsigned int format_val;
unsigned int maxbps;
+ unsigned int bps;
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
maxbps = dai->driver->playback.sig_bits;
else
maxbps = dai->driver->capture.sig_bits;
+ bps = snd_hdac_stream_format_bps(params_format(params), SNDRV_PCM_SUBFORMAT_STD, maxbps);
hda_pvt = snd_soc_component_get_drvdata(component);
- format_val = snd_hdac_calc_stream_format(params_rate(params),
- params_channels(params),
- params_format(params),
- maxbps,
- 0);
+ format_val = snd_hdac_stream_format(params_channels(params), bps, params_rate(params));
if (!format_val) {
dev_err(dai->dev,
"invalid format_val, rate=%d, ch=%d, format=%d, maxbps=%d\n",
--
2.25.1
next prev parent reply other threads:[~2023-11-16 11:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 11:22 [PATCH v4 00/16] ALSA/ASoC: hda: Address format selection limitations and ambiguity Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 01/16] ALSA: pcm: Introduce MSBITS subformat interface Cezary Rojewski
2023-11-16 15:10 ` Jaroslav Kysela
2023-11-17 11:45 ` Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 02/16] ALSA: hda: Honor subformat when querying PCMs Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 03/16] ASoC: pcm: Honor subformat when configuring runtime Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 04/16] ALSA: hda: Upgrade stream-format infrastructure Cezary Rojewski
2023-11-16 15:10 ` Jaroslav Kysela
2023-11-17 11:51 ` Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 05/16] ALSA: hda: Switch to new stream-format interface Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 06/16] ALSA: hda/hdmi: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 07/16] ALSA: hda/ca0132: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 08/16] ASoC: codecs: hda: " Cezary Rojewski
2023-11-16 11:22 ` Cezary Rojewski [this message]
2023-11-16 11:22 ` [PATCH v4 10/16] ASoC: codecs: hdac_hdmi: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 11/16] ASoC: Intel Skylake: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 12/16] ASoC: SOF: Intel: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 13/16] ASoC: Intel: avs: " Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 14/16] ALSA: hda: Drop snd_hdac_calc_stream_format() Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 15/16] ASoC: Intel: avs: Kill S24_LE format Cezary Rojewski
2023-11-16 11:22 ` [PATCH v4 16/16] ASoC: Intel: avs: Unhardcode HDAudio BE DAI drivers description Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116112255.1584795-10-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox