From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.com,
yung-chuan.liao@linux.intel.com
Subject: [PATCH 0/2] ASoC: SOF: ipc4-topology: Correct IPC message struct layouts
Date: Wed, 29 Nov 2023 15:14:09 +0200 [thread overview]
Message-ID: <20231129131411.27516-1-peter.ujfalusi@linux.intel.com> (raw)
Hi,
The SRC and GAIN module defined it's kernel side private struct in a way that
part of that is used as IPC message without making sure of proper alignment and
padding, which happens to work but it is better to be not 'clever' about these
sort of things.
The two patch corects this overlooked detail.
Regards,
Peter
---
Peter Ujfalusi (2):
ASoC: SOF: ipc4-topology: Correct data structures for the SRC module
ASoC: SOF: ipc4-topology: Correct data structures for the GAIN module
sound/soc/sof/ipc4-control.c | 20 +++++++-------
sound/soc/sof/ipc4-topology.c | 52 +++++++++++++++++------------------
sound/soc/sof/ipc4-topology.h | 34 +++++++++++++++++------
3 files changed, 61 insertions(+), 45 deletions(-)
--
2.43.0
next reply other threads:[~2023-11-29 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:14 Peter Ujfalusi [this message]
2023-11-29 13:14 ` [PATCH 1/2] ASoC: SOF: ipc4-topology: Correct data structures for the SRC module Peter Ujfalusi
2023-11-29 13:14 ` [PATCH 2/2] ASoC: SOF: ipc4-topology: Correct data structures for the GAIN module Peter Ujfalusi
2023-11-29 21:18 ` [PATCH 0/2] ASoC: SOF: ipc4-topology: Correct IPC message struct layouts Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129131411.27516-1-peter.ujfalusi@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox