From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <patches@opensource.cirrus.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-sound@vger.kernel.org>
Subject: Re: [PATCH 2/5] ASoC: wm1250-ev1: Convert to GPIO descriptors
Date: Fri, 8 Dec 2023 12:48:47 +0000 [thread overview]
Message-ID: <20231208124847.GT14858@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20231208124257.GQ14858@ediswmail.ad.cirrus.com>
On Fri, Dec 08, 2023 at 12:42:57PM +0000, Charles Keepax wrote:
> On Fri, Dec 08, 2023 at 11:09:26AM +0100, Linus Walleij wrote:
> > This converts the WM1250-EV1 codec to use GPIO descriptors.
> > It turns out that the platform data was only used to pass some
> > global GPIO numbers from a board file, so we get rid of this
> > and also switch over the single in-tree user in the S3C
> > Cragganmore module for S3C 6410.
> >
> > The driver obtains two GPIO lines named OSR and master and just
> > pull them low, we leave this behaviour as it was.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > + .table = {
> > + GPIO_LOOKUP("GPION", 12, "clk-ena", GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("GPIOL", 12, "clk-sel0", GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("GPIOL", 13, "clk-sel1", GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("GPIOL", 14, "osr", GPIO_ACTIVE_HIGH),
> > + GPIO_LOOKUP("GPIOL", 8, "master", GPIO_ACTIVE_HIGH),
> > + { },
>
> For my curiousity, what is the significance of GPION vs GPIOL here?
>
oops nvm I see it.
Thanks,
Charles
next prev parent reply other threads:[~2023-12-08 12:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 10:09 [PATCH 0/5] GPIO descriptor cleanup for some Wolfson codecs Linus Walleij
2023-12-08 10:09 ` [PATCH 1/5] ASoC: wm0010: Convert to GPIO descriptors Linus Walleij
2023-12-08 12:30 ` Charles Keepax
2023-12-08 15:43 ` Krzysztof Kozlowski
2023-12-08 10:09 ` [PATCH 2/5] ASoC: wm1250-ev1: " Linus Walleij
2023-12-08 12:42 ` Charles Keepax
2023-12-08 12:48 ` Charles Keepax [this message]
2023-12-08 15:43 ` Krzysztof Kozlowski
2023-12-08 10:09 ` [PATCH 3/5] ASoC: wm2200: " Linus Walleij
2023-12-08 12:45 ` Charles Keepax
2023-12-08 15:44 ` Krzysztof Kozlowski
2023-12-08 10:09 ` [PATCH 4/5] ASoC: wm5100: " Linus Walleij
2023-12-08 12:47 ` Charles Keepax
2023-12-08 15:44 ` Krzysztof Kozlowski
2023-12-08 10:09 ` [PATCH 5/5] ASoC: wm8996: " Linus Walleij
2023-12-08 12:50 ` Charles Keepax
2023-12-08 15:44 ` Krzysztof Kozlowski
2023-12-09 1:07 ` [PATCH 0/5] GPIO descriptor cleanup for some Wolfson codecs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208124847.GT14858@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox