Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: James Ogletree <James.Ogletree@cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jeff LaBundy <jeff@labundy.com>,
	"open list:CIRRUS LOGIC HAPTIC DRIVERS"
	<patches@opensource.cirrus.com>,
	"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
	<linux-sound@vger.kernel.org>
Subject: Re: [PATCH RESEND v10 5/5] ASoC: cs40l50: Support I2S streaming to CS40L50
Date: Wed, 17 Apr 2024 14:14:02 +0100	[thread overview]
Message-ID: <20240417131402.GZ2399047@google.com> (raw)
In-Reply-To: <F90648F7-BE0B-47DB-89C4-A8C91CD65D59@cirrus.com>

On Tue, 16 Apr 2024, James Ogletree wrote:

> 
> 
> > On Apr 16, 2024, at 7:35 AM, Lee Jones <lee@kernel.org> wrote:
> > 
> > On Fri, 12 Apr 2024, James Ogletree wrote:
> >> All feedback to date has been addressed
> > 
> > There are still MFD review comments left outstanding.
> 
> Hi Lee,
> 
> As best as I can tell, the only review comment in v10 is from you,
> saying that the MFD part looks okay. Then in this resent series, you
> commented that the MFD part had not been updated. Indeed, this is
> because there were no comments to address. Please correct me if I
> interpreted your comment incorrectly.
> 
> I have also gone back over v8 and v9 looking for outstanding
> comments, and all of the review comments appear to be applied.
> Would you kindly link me to the email with the missing review
> comments if I am mistaken?

At the very least, you still have this in here:

    /* If write never occurred, don't bother polling for ACK */

After realising that I'd commented on this before, I stopped the
re-review.

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-04-17 13:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 15:32 [PATCH RESEND v10 0/5] Add support for CS40L50 James Ogletree
2024-04-08 15:32 ` [PATCH RESEND v10 1/5] firmware: cs_dsp: Add write sequence interface James Ogletree
2024-04-08 15:32 ` [PATCH RESEND v10 2/5] dt-bindings: input: cirrus,cs40l50: Add initial DT binding James Ogletree
2024-04-08 15:32 ` [PATCH RESEND v10 3/5] mfd: cs40l50: Add support for CS40L50 core driver James Ogletree
2024-04-11 15:35   ` Lee Jones
2024-04-08 15:32 ` [PATCH RESEND v10 4/5] Input: cs40l50 - Add support for the CS40L50 haptic driver James Ogletree
2024-04-16 23:28   ` Dmitry Torokhov
2024-04-19 18:26     ` James Ogletree
2024-05-03 15:25       ` James Ogletree
2024-05-20 15:47         ` James Ogletree
2024-04-08 15:32 ` [PATCH RESEND v10 5/5] ASoC: cs40l50: Support I2S streaming to CS40L50 James Ogletree
2024-04-12 16:40   ` James Ogletree
2024-04-14  7:45     ` Mark Brown
2024-04-16 14:19       ` James Ogletree
2024-04-16 12:35     ` Lee Jones
2024-04-16 14:17       ` James Ogletree
2024-04-17 13:14         ` Lee Jones [this message]
2024-04-18 17:59           ` James Ogletree
2024-04-19 13:00             ` Lee Jones
2024-04-19 15:41               ` James Ogletree
2024-05-29 19:24   ` James Ogletree
2024-05-29 19:28     ` Mark Brown
2024-05-29 22:03     ` James Ogletree
2024-05-30 10:05       ` Mark Brown
2024-05-30 17:07   ` Rivera-Matos, Ricardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417131402.GZ2399047@google.com \
    --to=lee@kernel.org \
    --cc=James.Ogletree@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jeff@labundy.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox