Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: linux-sound@vger.kernel.org
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	Pietro Caruso <pietrocaruso50@gmail.com>
Subject: [PATCH v2 0/6] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock
Date: Sun, 28 Apr 2024 11:37:10 +0200	[thread overview]
Message-ID: <20240428093716.3198666-1-oswald.buddenhagen@gmx.de> (raw)

patches 1, 3 & 5 fix the regression(s), patch 4 fixes a related pre-existing
problem, patch 6 is a speculative fix on top of patch 4, and patch 2 is
logically part of patch 3, just factored out for legibility.

i don't think it really makes sense to revert fbb64eedf5a3 (ALSA: emu10k1: make
E-MU dock monitoring interrupt-driven) and re-do things from scratch, as we'd
also need to revert the unrelated c960b012ec47 (ALSA: emu10k1: track loss of
external clock on E-MU cards) first.

so i'd just fast-track the series as-is, and cherry-pick it to stable.

---

the series (and a bunch of failed experiments) is fully tested by pietro with
both rev1 and rev2 1010 cards, a 0202 cardbus card, and their respective docks.
he'll get permanent testing credits in the card capability table later on, so i
didn't bother adding a tested-by footer to each patch.

---
v2:
- split off non-bugfix part of the series
- add quotes around summaries in Fixes footers

Oswald Buddenhagen (6):
  ALSA: emu10k1: fix E-MU card dock presence monitoring
  ALSA: emu10k1: factor out snd_emu1010_load_dock_firmware()
  ALSA: emu10k1: move the whole GPIO event handling to the workqueue
  ALSA: emu10k1: use mutex for E-MU FPGA access locking
  ALSA: emu10k1: fix E-MU dock initialization
  ALSA: emu10k1: make E-MU FPGA writes potentially more reliable

 include/sound/emu10k1.h          |   7 +-
 sound/pci/emu10k1/emu10k1.c      |   3 +-
 sound/pci/emu10k1/emu10k1_main.c | 158 ++++++++++++++++++-------------
 sound/pci/emu10k1/emumixer.c     |  18 +++-
 sound/pci/emu10k1/emuproc.c      |   9 ++
 sound/pci/emu10k1/io.c           |  51 +++++-----
 6 files changed, 142 insertions(+), 104 deletions(-)

-- 
2.44.0.701.g2cf7baacf3.dirty


             reply	other threads:[~2024-04-28  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28  9:37 Oswald Buddenhagen [this message]
2024-04-28  9:37 ` [PATCH v2 1/6] ALSA: emu10k1: fix E-MU card dock presence monitoring Oswald Buddenhagen
2024-04-28  9:37 ` [PATCH v2 2/6] ALSA: emu10k1: factor out snd_emu1010_load_dock_firmware() Oswald Buddenhagen
2024-04-28  9:37 ` [PATCH v2 3/6] ALSA: emu10k1: move the whole GPIO event handling to the workqueue Oswald Buddenhagen
2024-04-28  9:37 ` [PATCH v2 4/6] ALSA: emu10k1: use mutex for E-MU FPGA access locking Oswald Buddenhagen
2024-04-28  9:37 ` [PATCH v2 5/6] ALSA: emu10k1: fix E-MU dock initialization Oswald Buddenhagen
2024-04-28  9:37 ` [PATCH v2 6/6] ALSA: emu10k1: make E-MU FPGA writes potentially more reliable Oswald Buddenhagen
2024-04-28 18:15 ` [PATCH v2 0/6] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240428093716.3198666-1-oswald.buddenhagen@gmx.de \
    --to=oswald.buddenhagen@gmx.de \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pietrocaruso50@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox