Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

Guenter Roeck
2024-05-17T18:00:27Z

On 5/17/24 10:48, Steven Rostedt wrote:
> On Fri, 17 May 2024 10:36:37 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> Building csky:allmodconfig (and others) ... failed
>> --------------
>> Error log:
>> In file included from include/trace/trace_events.h:419,
>> from include/trace/define_trace.h:102,
>> from drivers/cxl/core/trace.h:737,
>> from drivers/cxl/core/trace.c:8:
>> drivers/cxl/core/./trace.h:383:1: error: macro "__assign_str" passed 2 arguments, but takes just 1
>>
>> This is with the patch applied on top of v6.9-8410-gff2632d7d08e.
>> So far that seems to be the only build failure.
>> Introduced with commit 6aec00139d3a8 ("cxl/core: Add region info to
>> cxl_general_media and cxl_dram events"). Guess we'll see more of those
>> towards the end of the commit window.
>
> Looks like I made this patch just before this commit was pulled into
> Linus's tree.
>
> Which is why I'll apply and rerun the above again probably on Tuesday of
> next week against Linus's latest.
>
> This patch made it through both an allyesconfig and an allmodconfig, but on
> the commit I had applied it to, which was:
>
> 1b294a1f3561 ("Merge tag 'net-next-6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next")
>
> I'll be compiling those two builds after I update it then.
>

I am currently repeating my test builds with the above errors fixed.
That should take a couple of hours. I'll let you know how it goes.

Guenter