From: Manuel Barrio Linares <mbarriolinares@gmail.com>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org,
Manuel Barrio Linares <mbarriolinares@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jeremie Knuesel <knuesel@gmail.com>, Lukasz Tyl <ltyl@hem-e.com>,
Christos Skevis <xristos.thes@gmail.com>,
Jussi Laako <jussi@sonarnerd.net>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: usb-audio: Fix for sampling rates support for Mbox3
Date: Thu, 16 May 2024 10:40:02 -0300 [thread overview]
Message-ID: <20240516134003.39104-1-mbarriolinares@gmail.com> (raw)
In-Reply-To: <87ikze486g.wl-tiwai@suse.de>
Fixed wrong use of usb_sndctrlpipe to usb_rcvctrlpipe
Signed-off-by: Manuel Barrio Linares <mbarriolinares@gmail.com>
---
sound/usb/quirks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 2f961f0e9378..58156fbca02c 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1740,7 +1740,7 @@ static void mbox3_set_format_quirk(struct snd_usb_substream *subs,
u32 current_rate;
// Get current rate from card and check if changing it is needed
- snd_usb_ctl_msg(subs->dev, usb_sndctrlpipe(subs->dev, 0),
+ snd_usb_ctl_msg(subs->dev, usb_rcvctrlpipe(subs->dev, 0),
0x01, 0x21 | USB_DIR_IN, 0x0100, 0x8101, &buff4, 4);
current_rate = le32_to_cpu(buff4);
dev_dbg(&subs->dev->dev,
@@ -1765,7 +1765,7 @@ static void mbox3_set_format_quirk(struct snd_usb_substream *subs,
// Check whether the change was successful
buff4 = 0;
- snd_usb_ctl_msg(subs->dev, usb_sndctrlpipe(subs->dev, 0),
+ snd_usb_ctl_msg(subs->dev, usb_rcvctrlpipe(subs->dev, 0),
0x01, 0x21 | USB_DIR_IN, 0x0100, 0x8101, &buff4, 4);
if (new_rate != le32_to_cpu(buff4))
dev_warn(&subs->dev->dev, "MBOX3: Couldn't set the sample rate");
--
2.45.1
next parent reply other threads:[~2024-05-16 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ikze486g.wl-tiwai@suse.de>
2024-05-16 13:40 ` Manuel Barrio Linares [this message]
2024-05-16 14:02 ` [PATCH] ALSA: usb-audio: Fix for sampling rates support for Mbox3 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516134003.39104-1-mbarriolinares@gmail.com \
--to=mbarriolinares@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=jussi@sonarnerd.net \
--cc=knuesel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=ltyl@hem-e.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=xristos.thes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox