Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: linux-sound@vger.kernel.org
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 08/18] ASoC: Intel: sof_sdw: Add missing controls for cs42l43/cs35l56
Date: Mon, 27 May 2024 14:35:42 -0500	[thread overview]
Message-ID: <20240527193552.165567-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20240527193552.165567-1-pierre-louis.bossart@linux.intel.com>

From: Charles Keepax <ckeepax@opensource.cirrus.com>

No reason for cs42l43 and cs35l56 not to offer pin switch controls for
the headphones and speakers, add these controls.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index 9dc50a6d5301..0516ae660824 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -1059,6 +1059,8 @@ static struct sof_sdw_codec_info codec_info_list[] = {
 				.dailink = {SDW_AMP_OUT_DAI_ID, SDW_AMP_IN_DAI_ID},
 				.init = sof_sdw_cs_amp_init,
 				.rtd_init = cs_spk_rtd_init,
+				.controls = generic_spk_controls,
+				.num_controls = ARRAY_SIZE(generic_spk_controls),
 				.widgets = generic_spk_widgets,
 				.num_widgets = ARRAY_SIZE(generic_spk_widgets),
 			},
@@ -1094,6 +1096,8 @@ static struct sof_sdw_codec_info codec_info_list[] = {
 				.dai_type = SOF_SDW_DAI_TYPE_JACK,
 				.dailink = {SDW_JACK_OUT_DAI_ID, SDW_UNUSED_DAI_ID},
 				.rtd_init = cs42l43_hs_rtd_init,
+				.controls = generic_jack_controls,
+				.num_controls = ARRAY_SIZE(generic_jack_controls),
 				.widgets = generic_jack_widgets,
 				.num_widgets = ARRAY_SIZE(generic_jack_widgets),
 			},
@@ -1119,6 +1123,8 @@ static struct sof_sdw_codec_info codec_info_list[] = {
 				.dailink = {SDW_AMP_OUT_DAI_ID, SDW_UNUSED_DAI_ID},
 				.init = sof_sdw_cs42l43_spk_init,
 				.rtd_init = cs42l43_spk_rtd_init,
+				.controls = generic_spk_controls,
+				.num_controls = ARRAY_SIZE(generic_spk_controls),
 				.widgets = generic_spk_widgets,
 				.num_widgets = ARRAY_SIZE(generic_spk_widgets),
 				.quirk = SOF_CODEC_SPKR | SOF_SIDECAR_AMPS,
-- 
2.43.0


  parent reply	other threads:[~2024-05-27 19:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 19:35 [PATCH 00/18] ASoC: Intel: boards: updates for 6.11 Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 01/18] ASoC: Intel: sof_sdw_cs42l42: use dai parameter Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 02/18] ASoC: Intel: sof_sdw_rt711: " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 03/18] ASoC: Intel: sof_sdw_rt5682: " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 04/18] ASoC: Intel: sof_sdw_rt700: " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 05/18] ASoC: Intel: sof_sdw_rt_dmic: use from " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 06/18] ASoC: Intel: sof_sdw_rt_sdca_jack_common: use " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 07/18] ASoC: Intel: sof_sdw: remove get_codec_dai_by_name Pierre-Louis Bossart
2024-05-27 19:35 ` Pierre-Louis Bossart [this message]
2024-05-27 19:35 ` [PATCH 09/18] ASoC: Intel: soc-acpi: Add match entries for some cs42l43 laptops Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 10/18] ASoC: Intel: sof_sdw: Add quirks for some new Dell laptops Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 11/18] ASoC: Intel: sof_sdw: Add quirks from " Pierre-Louis Bossart
     [not found]   ` <446f90c8-87de-4a9f-8f40-ba544754dd15@linux.intel.com>
2024-05-29  8:51     ` Charles Keepax
2024-05-27 19:35 ` [PATCH 12/18] ASoC: SOF: sof-audio: rename dai clock setting query function Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 13/18] ASoC: SOF: sof-audio: add sof_dai_get_tdm_slots function Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 14/18] ASoC: SOF: ipc3-topology: support tdm slot number query Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 15/18] ASoC: SOF: ipc4-topology: " Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 16/18] ASoC: Intel: maxim-common: rewrite max_98373_hw_params function Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 17/18] ASoC: Intel: sof_da7219: remove local max98373 ops Pierre-Louis Bossart
2024-05-27 19:35 ` [PATCH 18/18] ASoC: Intel: sof_da7219: disable max98373 speaker pins in late_probe Pierre-Louis Bossart
2024-08-28 17:36 ` [PATCH 00/18] ASoC: Intel: boards: updates for 6.11 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527193552.165567-9-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox