From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: linux-sound@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com,
seppo.ingalsuo@linux.intel.com, yung-chuan.liao@linux.intel.com
Subject: [PATCH 6.10 0/5] ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection
Date: Thu, 30 May 2024 14:19:13 +0300 [thread overview]
Message-ID: <20240530111918.21974-1-peter.ujfalusi@linux.intel.com> (raw)
Hi,
the existing logic to pick a DMIC blob is based on several historical assumptions
that the NHLT in BIOS always contains 32-bits per sample type (first patch, [1]).
The other issue with the existing logic is that it was designed to care only
about the bit depth of the format and fails to find the existing and correct
blob when rate/channels are different on the FE side compared to what we should
be using on the DAI side (we have components in path which can change
rate/channel count).
These issues have not been observed in past but with new MTL based (Windows)
laptops and new topologies to enhance the audio quality, we started to see weird
issues around how our assumptions of vendors failed.
Since some NHLT blob handling cleanup has been done for 6.10, this series will
complete that work to cover even cases that we don't anticipate to see.
[1] https://github.com/thesofproject/linux/issues/4973
Regards,
Peter
---
Peter Ujfalusi (5):
ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC
blob
ASoC: SOF: ipc4-topology: Print out the channel count in
sof_ipc4_dbg_audio_format
ASoC: SOF: ipc4-topology/pcm: Rename
sof_ipc4_copier_is_single_format()
ASoC: SOF: ipc4-topology: Improve readability of
sof_ipc4_prepare_dai_copier()
ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats
sound/soc/sof/ipc4-pcm.c | 12 +--
sound/soc/sof/ipc4-topology.c | 155 +++++++++++++++++++++++-----------
sound/soc/sof/ipc4-topology.h | 6 +-
3 files changed, 115 insertions(+), 58 deletions(-)
--
2.45.1
next reply other threads:[~2024-05-30 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 11:19 Peter Ujfalusi [this message]
2024-05-30 11:19 ` [PATCH 6.10 1/5] ASoC: SOF: ipc4-topology: Add support for NHLT with 16-bit only DMIC blob Peter Ujfalusi
2024-05-30 11:19 ` [PATCH 6.10 2/5] ASoC: SOF: ipc4-topology: Print out the channel count in sof_ipc4_dbg_audio_format Peter Ujfalusi
2024-05-30 11:19 ` [PATCH 6.10 3/5] ASoC: SOF: ipc4-topology/pcm: Rename sof_ipc4_copier_is_single_format() Peter Ujfalusi
2024-05-30 11:19 ` [PATCH 6.10 4/5] ASoC: SOF: ipc4-topology: Improve readability of sof_ipc4_prepare_dai_copier() Peter Ujfalusi
2024-05-30 11:19 ` [PATCH 6.10 5/5] ASoC: SOF: ipc4-topology: Adjust the params based on DAI formats Peter Ujfalusi
2024-05-30 15:21 ` [PATCH 6.10 0/5] ASoC: SOF: ipc4-topology: Fix nhlt configuration blob selection Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530111918.21974-1-peter.ujfalusi@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=seppo.ingalsuo@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox