From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <venkataprasad.potturu@amd.com>,
<Basavaraj.Hiregoudar@amd.com>, <Sunil-kumar.Dommati@amd.com>,
"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Syed Saba Kareem" <Syed.SabaKareem@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
<linux-sound@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 7/8] ASoC: amd: acp: move i2s clock generation sequence
Date: Mon, 17 Jun 2024 12:58:40 +0530 [thread overview]
Message-ID: <20240617072844.871468-7-Vijendar.Mukunda@amd.com> (raw)
In-Reply-To: <20240617072844.871468-1-Vijendar.Mukunda@amd.com>
I2S clock generation registers should be programmed before starting the I2S
dma when I2S controller is programmed as clock master. Move i2s clock
generation register programming sequence prior to i2s dma start.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
sound/soc/amd/acp/acp-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c
index 7da414bc3b96..88985e9d318b 100644
--- a/sound/soc/amd/acp/acp-i2s.c
+++ b/sound/soc/amd/acp/acp-i2s.c
@@ -369,12 +369,12 @@ static int acp_i2s_trigger(struct snd_pcm_substream *substream, int cmd, struct
}
writel(period_bytes, adata->acp_base + water_val);
writel(buf_size, adata->acp_base + buf_reg);
+ if (rsrc->soc_mclk)
+ acp_set_i2s_clk(adata, dai->driver->id);
val = readl(adata->acp_base + reg_val);
val = val | BIT(0);
writel(val, adata->acp_base + reg_val);
writel(1, adata->acp_base + ier_val);
- if (rsrc->soc_mclk)
- acp_set_i2s_clk(adata, dai->driver->id);
return 0;
case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_SUSPEND:
--
2.34.1
next prev parent reply other threads:[~2024-06-17 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 7:28 [PATCH 1/8] ASoC: amd: acp: add a null check for chip_pdev structure Vijendar Mukunda
2024-06-17 7:28 ` [PATCH 2/8] ASoC: amd: acp: remove i2s configuration check in acp_i2s_probe() Vijendar Mukunda
2024-06-17 7:28 ` [PATCH 3/8] ASoC: amd: acp: move chip->flag variable assignment Vijendar Mukunda
2024-06-17 7:28 ` [PATCH 4/8] ASoC: amd: acp: remove acp_i2s_probe function Vijendar Mukunda
2024-06-17 7:28 ` [PATCH 5/8] ASoC: amd: acp: remove unused variables from acp_resource structure Vijendar Mukunda
2024-06-17 7:28 ` [PATCH 6/8] ASoC: amd: acp: modify conditional check for programming i2s mclk Vijendar Mukunda
2024-06-17 7:28 ` Vijendar Mukunda [this message]
2024-06-17 7:28 ` [PATCH 8/8] ASoC: amd: acp: add pcm constraints for buffer size and period size Vijendar Mukunda
2024-06-20 11:47 ` (subset) [PATCH 1/8] ASoC: amd: acp: add a null check for chip_pdev structure Mark Brown
2024-06-23 10:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617072844.871468-7-Vijendar.Mukunda@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox