Re: [PATCH v3] ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients

Takashi Iwai
2024-08-05T07:48:56Z

On Thu, 01 Aug 2024 16:31:39 +0200,
Simon Trimmer wrote:
>
> A number of laptops have gone to market with old firmware versions that
> export controls that have since been hidden, but we can't just install a
> newer firmware because the firmware for each product is customized and
> qualified by the OEM. The issue is that alsactl save and restore has no
> idea what controls are good to persist which can lead to
> misconfiguration.
>
> There is no reason that the UCM or user should need to interact with any
> of the ALSA controls for the firmware coefficients so they can be
> removed entirely, this also simplifies the driver.
>
> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
> ---
> Changes in v3:
> - Remove ability to add firmware coefficients as ALSA controls
> entirely
>
> Changes in v2:
> - v1 was accidentally the backport version for older kernels instead of
> the one for v6.11

Applied now to for-linus branch. Thanks.

Takashi