Re: [PATCH AUTOSEL 6.9 17/40] ASoC: topology: Fix route memory corruption

Vitaly Chikunov
2024-08-12T10:38:48Z

Greg,

On Mon, Aug 12, 2024 at 12:25:54PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 12, 2024 at 12:01:48PM +0200, Amadeusz Sławiński wrote:
> > I guess that for completeness you need to apply both patches:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=97ab304ecd95c0b1703ff8c8c3956dc6e2afe8e1
>
> This is already in the tree.
>
> > was an incorrect fix which was later fixed by:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/sound/soc/soc-topology.c?id=0298f51652be47b79780833e0b63194e1231fa34
>
> This commit will not apply :(

It depends upon e0e7bc2cbee9 ("ASoC: topology: Clean up route loading"),
which was in the same patchset that didn't get applied.

https://lore.kernel.org/stable/?q=ASoC%3A+topology%3A+Clean+up+route+loading

I see, Mark Brown said it's not suitable material for stable kernels
(since it's code cleanup), and Sasha Levin dropped it, and the dependent
commit with real fix.

Thanks,

>
> > Applying just first one will result in runtime problems, while applying just
> > second one will result in missing NULL checks on allocation.
>
> The second patch can not apply to the stable trees, so we need a
> backported version please.
>
> thanks,
>
> greg k-h