Re: [PATCH 1/2] ASoC: sma1307: Add driver for Iron Device SMA1307

[kernel test robot <lkp@intel.com>]

Hi Kiseok,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.11-rc3 next-20240814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kiseok-Jo/ASoC-sma1307-Add-driver-for-Iron-Device-SMA1307/20240815-001157
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20240813052609.56527-2-kiseok.jo%40irondevice.com
patch subject: [PATCH 1/2] ASoC: sma1307: Add driver for Iron Device SMA1307
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240815/202408151223.etnjDl4b-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408151223.etnjDl4b-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408151223.etnjDl4b-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/sma1307.c:2191:2: warning: switch condition has boolean value [-Wswitch-bool]
    2191 |         switch (sma1307->amp_set) {
         |         ^       ~~~~~~~~~~~~~~~~
   1 warning generated.


vim +2191 sound/soc/codecs/sma1307.c

  2159	
  2160	static void sma1307_reset(struct snd_soc_component *component)
  2161	{
  2162		struct sma1307_priv *sma1307 = snd_soc_component_get_drvdata(component);
  2163		int ret = 0;
  2164		unsigned int status = 0;
  2165	
  2166		dev_dbg(sma1307->dev, "%s: Reset start\n", __func__);
  2167		ret = sma1307_regmap_read(sma1307, SMA1307_FF_DEVICE_INDEX, &status);
  2168	
  2169		if (ret != 0)
  2170			dev_err(sma1307->dev,
  2171				"%s: failed to read SMA1307_FF_DEVICE_INDEX : %d\n",
  2172				__func__, ret);
  2173		else {
  2174			sma1307->rev_num = status & SMA1307_REV_NUM_STATUS;
  2175			dev_dbg(component->dev,
  2176				 "%s: SMA1307 Revision %d\n",
  2177				 __func__, sma1307->rev_num);
  2178		}
  2179	
  2180		sma1307_regmap_read(sma1307, SMA1307_99_OTP_TRM2, &sma1307->otp_trm2);
  2181		sma1307_regmap_read(sma1307, SMA1307_9A_OTP_TRM3, &sma1307->otp_trm3);
  2182	
  2183		if ((sma1307->otp_trm2 & SMA1307_OTP_STAT_MASK) == SMA1307_OTP_STAT_1)
  2184			dev_dbg(component->dev, "%s: SMA1307 OTP Status Successful\n",
  2185				 __func__);
  2186		else
  2187			dev_dbg(component->dev, "%s: SMA1307 OTP Status Fail\n",
  2188				 __func__);
  2189	
  2190		/* Register Initial Value Setting */
> 2191		switch (sma1307->amp_set) {
  2192		case SMA1307_DEFAULT_SET:
  2193			sma1307_set_default(component);
  2194			break;
  2195		case SMA1307_BINARY_FILE_SET:
  2196			sma1307_setting_loaded(sma1307, setting_file);
  2197			if (sma1307->set.status) {
  2198				sma1307_set_binary(component);
  2199			} else {
  2200				sma1307->force_mute_status = true;
  2201				sma1307_set_default(component);
  2202			}
  2203			break;
  2204		}
  2205		sma1307_regmap_update_bits(sma1307,
  2206					   SMA1307_93_INT_CTRL,
  2207					   SMA1307_DIS_INT_MASK, SMA1307_HIGH_Z_INT);
  2208		sma1307_regmap_write(sma1307, SMA1307_0A_SPK_VOL, sma1307->init_vol);
  2209	}
  2210	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki