From: Artur Weber <aweber.kernel@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH RESEND v2 1/6] ASoC: dt-bindings: midas-audio: Declare required properties for GPIO jack det
Date: Fri, 16 Aug 2024 09:50:58 +0200 [thread overview]
Message-ID: <20240816-midas-audio-tab3-v2-1-48ee7f2293b3@gmail.com> (raw)
In-Reply-To: <20240816-midas-audio-tab3-v2-0-48ee7f2293b3@gmail.com>
GPIO jack detection requires an IIO channel and the detection threshold
to work. Explicitly declare the requirement in DT schema.
Fixes: 0a590ecc672a ("ASoC: dt-bindings: samsung,midas-audio: Add GPIO-based headset jack detection")
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v2:
- Use anyOf instead of oneOf in headset-detect-gpios/headset-key-gpios
if: statement
---
.../bindings/sound/samsung,midas-audio.yaml | 29 +++++++++++++++++++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
index 69ddfd4afdcd..5483421a6fd3 100644
--- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml
@@ -9,9 +9,6 @@ title: Samsung Midas audio complex with WM1811 codec
maintainers:
- Sylwester Nawrocki <s.nawrocki@samsung.com>
-allOf:
- - $ref: sound-card-common.yaml#
-
properties:
compatible:
const: samsung,midas-audio
@@ -102,6 +99,32 @@ required:
- mic-bias-supply
- submic-bias-supply
+allOf:
+ - $ref: sound-card-common.yaml#
+
+ - if:
+ anyOf:
+ - required: [ headset-detect-gpios ]
+ - required: [ headset-key-gpios ]
+ then:
+ required:
+ - io-channels
+ - io-channel-names
+
+ - if:
+ required:
+ - headset-detect-gpios
+ then:
+ required:
+ - samsung,headset-4pole-threshold-microvolt
+
+ - if:
+ required:
+ - headset-key-gpios
+ then:
+ required:
+ - samsung,headset-button-threshold-microvolt
+
unevaluatedProperties: false
examples:
--
2.46.0
next prev parent reply other threads:[~2024-08-16 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 7:50 [PATCH RESEND v2 0/6] ASoC: samsung: midas_wm1811: Separate compatible for tab3 + fixes Artur Weber
2024-08-16 7:50 ` Artur Weber [this message]
2024-08-16 7:57 ` [PATCH RESEND v2 1/6] ASoC: dt-bindings: midas-audio: Declare required properties for GPIO jack det Artur Weber
2024-08-16 22:35 ` Rob Herring (Arm)
2024-08-16 7:50 ` [PATCH RESEND v2 2/6] ASoC: dt-bindings: midas-audio: Add separate compatible for tab3 audio Artur Weber
2024-08-16 7:51 ` [PATCH RESEND v2 3/6] ARM: dts: samsung: exynos4212-tab3: Fix headset mic, add jack detection Artur Weber
2024-08-16 7:51 ` [PATCH RESEND v2 4/6] ARM: dts: samsung: exynos4212-tab3: Add MCLK2 clock to WM1811 codec config Artur Weber
2024-08-16 7:51 ` [PATCH RESEND v2 5/6] ARM: dts: samsung: exynos4212-tab3: Drop interrupt from WM1811 codec Artur Weber
2024-08-16 7:51 ` [PATCH RESEND v2 6/6] ARM: dts: samsung: exynos4212-tab3: Drop dummy mic bias regulators Artur Weber
2024-12-29 10:06 ` Krzysztof Kozlowski
2024-12-29 10:10 ` (subset) [PATCH RESEND v2 0/6] ASoC: samsung: midas_wm1811: Separate compatible for tab3 + fixes Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816-midas-audio-tab3-v2-1-48ee7f2293b3@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox