From: 唐彬 <tangbin@cmss.chinamobile.com>
To: broonie <broonie@kernel.org>
Cc: lgirdwood <lgirdwood@gmail.com>, perex <perex@perex.cz>,
tiwai <tiwai@suse.com>, matthias.bgg <matthias.bgg@gmail.com>,
angelogioacchino.delregno
<angelogioacchino.delregno@collabora.com>,
linux-sound <linux-sound@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: Re: [PATCH 1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments
Date: Thu, 10 Oct 2024 17:55:09 +0800 [thread overview]
Message-ID: <202410101755089538782@cmss.chinamobile.com> (raw)
In-Reply-To: ZwejOZQlSsWbAWBg@finisterre.sirena.org.uk
I am sorry, it's my mistake. I know the rule, just mistake.
From: Mark Brown
Date: 2024-10-10 17:49
To: Tang Bin
CC: lgirdwood; perex; tiwai; matthias.bgg; angelogioacchino.delregno; linux-sound; linux-kernel; linux-arm-kernel; linux-mediatek
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments
On Thu, Oct 10, 2024 at 03:35:47PM +0800, Tang Bin wrote:
> In the function mtk_dai_hdmitx_dptx_hw_params, the variable
> 'ret' is redundant, thus remove it.
Please don't send patch serieses without cover letters, having a cover
letter makes it easier to tell why the series is a series and makes it
easier for tooling to work with the series.
next prev parent reply other threads:[~2024-10-10 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 7:35 [PATCH 1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments Tang Bin
2024-10-10 9:49 ` Mark Brown
2024-10-10 9:55 ` 唐彬 [this message]
2024-10-10 11:01 ` Matthias Brugger
2024-10-10 12:51 ` Mark Brown
2024-10-10 11:00 ` Matthias Brugger
2024-10-11 15:23 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410101755089538782@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox