Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: tiwai@suse.com
Cc: linux-sound@vger.kernel.org, broonie@kernel.org, perex@perex.cz,
	amadeuszx.slawinski@linux.intel.com,
	Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v2 0/2] ALSA: hda: Compilation and firmware-loading fixes
Date: Fri, 10 Jan 2025 12:33:24 +0100	[thread overview]
Message-ID: <20250110113326.3809897-1-cezary.rojewski@intel.com> (raw)

Small set of fixes, one of which addresses the compilation issues with
snd_hdac_adsp_xxx() macros utilized currently by the avs-driver alone.

The more impactful change updates the firmware loading flow so that the
binary is loaded in two chunks rather than just one. This is to follow
recommendation from the hardware team: SDxLVI is expected to be at least
1 (0-index based so 1+1=2 BDL entries) when performing any data
transfer.

Changes in v2:
- removed the type-mismatch fixing patch as suggested by Takashi
- relocated snd_hdac_adsp_xxx() macros to avs/ space as suggested by
  Jaroslav and Takashi


Cezary Rojewski (2):
  ALSA: hda: Fix compilation of snd_hdac_adsp_xxx() helpers
  ALSA: hda: Transfer firmware in two chunks

 include/sound/hdaudio_ext.h     | 45 ---------------------------------
 sound/hda/hdac_stream.c         |  3 ++-
 sound/soc/intel/avs/apl.c       |  1 +
 sound/soc/intel/avs/cnl.c       |  1 +
 sound/soc/intel/avs/registers.h | 45 +++++++++++++++++++++++++++++++++
 sound/soc/intel/avs/skl.c       |  1 +
 6 files changed, 50 insertions(+), 46 deletions(-)

-- 
2.25.1


             reply	other threads:[~2025-01-10 11:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 11:33 Cezary Rojewski [this message]
2025-01-10 11:33 ` [PATCH v2 1/2] ALSA: hda: Fix compilation of snd_hdac_adsp_xxx() helpers Cezary Rojewski
2025-01-10 16:29   ` Takashi Iwai
2025-01-10 16:31     ` Mark Brown
2025-01-10 16:47       ` Takashi Iwai
2025-01-10 18:03         ` Mark Brown
2025-01-10 11:33 ` [PATCH v2 2/2] ALSA: hda: Transfer firmware in two chunks Cezary Rojewski
2025-01-10 16:44   ` Takashi Iwai
2025-01-10 16:57     ` Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250110113326.3809897-1-cezary.rojewski@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox