From: Takashi Iwai <tiwai@suse.de>
To: linux-sound@vger.kernel.org
Cc: "Geoffrey D . Bennett" <g@b4.vu>
Subject: [PATCH 2/3] ALSA: usb: fcp: Fix incorrect resp->opcode retrieval
Date: Tue, 21 Jan 2025 18:00:30 +0100 [thread overview]
Message-ID: <20250121170032.7236-3-tiwai@suse.de> (raw)
In-Reply-To: <20250121170032.7236-1-tiwai@suse.de>
Fix a wrong conversion macro used for resp->opcode, which is __le32.
Fixes: 46757a3e7d50 ("ALSA: FCP: Add Focusrite Control Protocol driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501212331.SaePSmsA-lkp@intel.com/
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/usb/fcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/fcp.c b/sound/usb/fcp.c
index 92e3caab0b82..cfa131b35e43 100644
--- a/sound/usb/fcp.c
+++ b/sound/usb/fcp.c
@@ -266,7 +266,7 @@ static int fcp_usb(struct usb_mixer_interface *mixer, u32 opcode,
if (req->opcode != resp->opcode) {
usb_audio_err(mixer->chip,
"FCP response %08x opcode mismatch %08x\n",
- opcode, le16_to_cpu(resp->opcode));
+ opcode, le32_to_cpu(resp->opcode));
return -EINVAL;
}
--
2.43.0
next prev parent reply other threads:[~2025-01-21 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 17:00 [PATCH 0/3] ALSA: usb: fcp: Fix sparse warnings Takashi Iwai
2025-01-21 17:00 ` [PATCH 1/3] ALSA: usb: fcp: Fix meter_levels type to __le32 Takashi Iwai
2025-01-21 17:00 ` Takashi Iwai [this message]
2025-01-21 17:00 ` [PATCH 3/3] ALSA: usb: fcp: Fix return code from poll ops Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121170032.7236-3-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=g@b4.vu \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox