From: jack Livingood <jacklivingood@comcast.net>
To: clemens@ladisch.de
Cc: o-takashi@sakamocchi.jp, linux-sound@vger.kernel.org,
Jack Livingood <jacklivingood@comcast.net>
Subject: [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy
Date: Wed, 5 Feb 2025 11:22:58 -0800 [thread overview]
Message-ID: <20250205192258.358362-1-jacklivingood@comcast.net> (raw)
From: Jack Livingood <jacklivingood@comcast.net>
changed strcpy to strscpy in order to prevent a possible linear
overflow.
Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
---
sound/firewire/isight.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
index 806f82c9ceee..e9617fc0a532 100644
--- a/sound/firewire/isight.c
+++ b/sound/firewire/isight.c
@@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit,
card->private_free = isight_card_free;
- strcpy(card->driver, "iSight");
- strcpy(card->shortname, "Apple iSight");
+ strscpy(card->driver, "iSight");
+ strscpy(card->shortname, "Apple iSight");
snprintf(card->longname, sizeof(card->longname),
"Apple iSight (GUID %08x%08x) at %s, S%d",
fw_dev->config_rom[3], fw_dev->config_rom[4],
dev_name(&unit->device), 100 << fw_dev->max_speed);
- strcpy(card->mixername, "iSight");
+ strspy(card->mixername, "iSight");
err = isight_create_pcm(isight);
if (err < 0)
--
2.48.1
next reply other threads:[~2025-02-05 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 19:22 jack Livingood [this message]
2025-02-06 0:26 ` [PATCH 1/2] sounds: firewire: isight: changed strcpy to strscpy Takashi Sakamoto
2025-02-10 17:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205192258.358362-1-jacklivingood@comcast.net \
--to=jacklivingood@comcast.net \
--cc=clemens@ladisch.de \
--cc=linux-sound@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox