Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Yazen Ghannam <yazen.ghannam@amd.com>,
	Borislav Petkov <bp@alien8.de>, Mark Brown <broonie@kernel.org>
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
	"H . Peter Anvin" <hpa@zytor.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Bard Liao" <yung-chuan.liao@linux.intel.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
	"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>,
	"Venkata Prasad Potturu" <venkataprasad.potturu@amd.com>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	linux-kernel@vger.kernel.org (open list:AMD NODE DRIVER),
	linux-sound@vger.kernel.org (open list:SOUND - SOC LAYER /
	DYNAMIC AUDIO POWER MANAGEM...),
	sound-open-firmware@alsa-project.org (moderated list:SOUND -
	SOUND OPEN FIRMWARE (SOF) DRIVERS)
Subject: [PATCH 1/7] x86/amd_node: Add a helper for use with `read_poll_timeout`
Date: Mon, 17 Feb 2025 17:17:41 -0600	[thread overview]
Message-ID: <20250217231747.1656228-2-superm1@kernel.org> (raw)
In-Reply-To: <20250217231747.1656228-1-superm1@kernel.org>

From: Mario Limonciello <mario.limonciello@amd.com>

Some of the ACP drivers will poll registers through SMN using
`read_poll_timeout` which requires returning the result of the register
read as the argument.

Add a helper to do just that.

Tested by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 arch/x86/include/asm/amd_node.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/x86/include/asm/amd_node.h b/arch/x86/include/asm/amd_node.h
index 113ad3e8ee40a..9f3f613366f7d 100644
--- a/arch/x86/include/asm/amd_node.h
+++ b/arch/x86/include/asm/amd_node.h
@@ -33,4 +33,15 @@ static inline u16 amd_num_nodes(void)
 int __must_check amd_smn_read(u16 node, u32 address, u32 *value);
 int __must_check amd_smn_write(u16 node, u32 address, u32 value);
 
+/* helper for use with read_poll_timeout */
+static inline int smn_read_register(u32 reg)
+{
+	int data, rc;
+
+	rc = amd_smn_read(0, reg, &data);
+	if (rc)
+		return rc;
+
+	return data;
+}
 #endif /*_ASM_X86_AMD_NODE_H_*/
-- 
2.43.0


  reply	other threads:[~2025-02-17 23:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 23:17 [PATCH 0/7] Adjust all AMD audio drivers to use AMD_NODE Mario Limonciello
2025-02-17 23:17 ` Mario Limonciello [this message]
2025-02-17 23:17 ` [PATCH 2/7] ASoC: amd: acp: rembrandt: Use AMD_NODE Mario Limonciello
2025-02-17 23:17 ` [PATCH 3/7] ASoC: amd: acp: acp70: " Mario Limonciello
2025-02-17 23:17 ` [PATCH 4/7] ASoC: amd: acp: acp63: " Mario Limonciello
2025-02-17 23:17 ` [PATCH 5/7] ASoC: SOF: amd: " Mario Limonciello
2025-02-17 23:17 ` [PATCH 6/7] ASoC: amd: acp: Drop local symbols for smn read/write Mario Limonciello
2025-02-17 23:17 ` [PATCH 7/7] ASoC: SOF: amd: Drop host bridge ID from struct Mario Limonciello
2025-02-18 15:11 ` [PATCH 0/7] Adjust all AMD audio drivers to use AMD_NODE Mark Brown
2025-02-18 15:16   ` Mario Limonciello
2025-02-18 15:26     ` Borislav Petkov
2025-02-18 15:33       ` Mario Limonciello
2025-02-18 17:26         ` Borislav Petkov
2025-02-18 17:29           ` Mario Limonciello
2025-02-19 23:08 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217231747.1656228-2-superm1@kernel.org \
    --to=superm1@kernel.org \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=quic_jjohnson@quicinc.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=venkataprasad.potturu@amd.com \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox