Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: kernel@collabora.com, linux-sound@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes
Date: Fri, 21 Feb 2025 21:39:32 +0100	[thread overview]
Message-ID: <20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com> (raw)

Some tools like KGraphViewer interpret the "ON" nodes not having an
explicitly set fill colour as them being entirely black, which obscures
the text on them and looks funny. In fact, I thought they were off for
the longest time. Comparing to the output of the `dot` tool, I assume
they are supposed to be white.

Instead of speclawyering over who's in the wrong and must immediately
atone for their wickedness at the altar of RFC2119, just be explicit
about it, set the fillcolor to white, and nobody gets confused.

Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
This is somewhat "just thrown out there"; I noticed that not setting the
fill colour breaks KGraphViewer only *after* I thought this was just how
they were for several days. With this change, both dot and KGraphViewer
render it correctly, but I have no clue as to whether it's in the spirit
of the file format at all. I figure that if this saves some other poor
souls a bit of time and confusion, then it's worth it.
---
 tools/sound/dapm-graph | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/sound/dapm-graph b/tools/sound/dapm-graph
index f14bdfedee8f11507a6b7b04f6dd1847513e6da8..b6196ee5065a4e72069df663775518352d75d410 100755
--- a/tools/sound/dapm-graph
+++ b/tools/sound/dapm-graph
@@ -10,7 +10,7 @@ set -eu
 
 STYLE_COMPONENT_ON="color=dodgerblue;style=bold"
 STYLE_COMPONENT_OFF="color=gray40;style=filled;fillcolor=gray90"
-STYLE_NODE_ON="shape=box,style=bold,color=green4"
+STYLE_NODE_ON="shape=box,style=bold,color=green4,fillcolor=white"
 STYLE_NODE_OFF="shape=box,style=filled,color=gray30,fillcolor=gray95"
 
 # Print usage and exit

---
base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319
change-id: 20250221-dapm-graph-node-colour-eb0011a45856

Best regards,
-- 
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>


             reply	other threads:[~2025-02-21 20:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 20:39 Nicolas Frattaroli [this message]
2025-02-24 15:33 ` [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes Luca Ceresoli
2025-02-24 15:42   ` Mark Brown
2025-02-24 16:09     ` Nicolas Frattaroli
2025-02-24 16:21       ` Mark Brown
2025-02-25 13:38 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com \
    --to=nicolas.frattaroli@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox