From: Andrei Simion <andrei.simion@microchip.com>
To: <thorsten.blum@linux.dev>
Cc: <alexandre.belloni@bootlin.com>, <andrei.simion@microchip.com>,
<broonie@kernel.org>, <claudiu.beznea@tuxon.dev>,
<lgirdwood@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<nicolas.ferre@microchip.com>, <perex@perex.cz>, <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper
Date: Mon, 24 Feb 2025 09:26:15 +0200 [thread overview]
Message-ID: <20250224072614.6811-1-andrei.simion@microchip.com> (raw)
In-Reply-To: <20250222225925.539840-2-thorsten.blum@linux.dev>
Hi,
On 23.02.2025 00:59, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Andrei Simion <andrei.simion@microchip.com>
> ---
> sound/soc/atmel/atmel-classd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index ba314b279919..1f8c60d2de82 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -11,6 +11,7 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> +#include <linux/string_choices.h>
> #include <sound/core.h>
> #include <sound/dmaengine_pcm.h>
> #include <sound/pcm_params.h>
> @@ -275,7 +276,7 @@ static int atmel_classd_component_probe(struct snd_soc_component *component)
> dev_info(component->dev,
> "PWM modulation type is %s, non-overlapping is %s\n",
> pwm_type[pdata->pwm_type],
> - pdata->non_overlap_enable?"enabled":"disabled");
> + str_enabled_disabled(pdata->non_overlap_enable));
>
> return 0;
> }
Best Regards,
Andrei Simion
next prev parent reply other threads:[~2025-02-24 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 22:59 [PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper Thorsten Blum
2025-02-24 7:26 ` Andrei Simion [this message]
2025-02-25 13:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224072614.6811-1-andrei.simion@microchip.com \
--to=andrei.simion@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox