Re: [PATCH V2 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Thu, Mar 06, 2025 at 03:47:27PM +0000, David Turner wrote:
> Hi all,
> 
> On Thu, 6 Mar 2025 at 13:39, Maxime Ripard <mripard@kernel.org> wrote:
> > It looks fairly generic to me. Is there any reason you didn't put it in
> > the HDMI audio helpers?
> 
> I originally wrote the downstream patch last year on 6.6, before the
> generic HDMI audio code existed.
> 
> I just had a look at doing this.  At the moment drm_hdmi_audio_helper
> doesn't manage the snd_soc_card (needed to setup the jack) at all,
> that still lives in vc4_hdmi_audio, so I can't see an easy way to move
> this over without a lot more reorganising.


Ah, yes, of course. Most (all?) the other drivers just use an external
I2S controller so the card is mostly likely going to be described
through simple-card.

I guess we can always turn that code into a helper if a similar case
comes along in the future.

Thanks,
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]