From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D070B1A3163; Mon, 17 Mar 2025 16:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742229567; cv=none; b=jFVjAWoaRA5osAClF+lIcpC2TRVVTldBRVOo7W/h2VfCyTu1Gs29lyyWx1DhSwYHjAS1JoGJuN+D+DtAGwcWKEdv3RTnM4tXwt2q/wMCmmZt1+yIwv0Km1cOk9SV/WuU6aRIacFokzr05GOV2KhBShdHa69pbctEDQtYam63WbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742229567; c=relaxed/simple; bh=UeiSQ/hkKZrLMmRLhZRiXRYof6CAysj/kL5O0U1ITzQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DSV8r8SfsTuPFhWLa8S170k3mgvDYjaqTcjO4haAh9b7NnMNoxUX1iahi7xtLgPgmofJW1ivJR6V4H69loOOrrEMqNM7Z4ONKJQEq5fQxnDLxLGqOdY6LKwpmSWmyMGVEofCB8pEE4ITe8JLFdX4OGCjOMFiPE3ga7ubMF5DgwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XTbEQuVL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XTbEQuVL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4C3FC4CEF8; Mon, 17 Mar 2025 16:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742229567; bh=UeiSQ/hkKZrLMmRLhZRiXRYof6CAysj/kL5O0U1ITzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XTbEQuVLqHPydBk0FrNCgEYgCttYQB3R3WWTdaXY0MV4FakArqD+AqxhWe+KWJIIL sMJvdjqA/TOvnbNWlEANkuhfHx48J83bIzl5A7gyftaSjI1wmASP9CQzfBHKQyk/SP 2larwp95NEjfelm/+fa6Yo25crvxu0X/FkeHiSm+H7xe1xuc0zL/15BvmGmylpHa9a 8v+JP8PM/6Kib/+wZ0otIeerNvNn7jwPbAO1Dop1mOWefXZ++gJQgYLQ+nDKBQG585 GKq2IXIT0mb6zgrwaJQaoMkWoZptWWVOxH0mYTqIQWlh+C1mUSuvpFEnMpvl61nvlQ S6qZU+oQQnGVw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navon John Lukose , Takashi Iwai , Sasha Levin , perex@perex.cz, tiwai@suse.com, kailang@realtek.com, sbinding@opensource.cirrus.com, simont@opensource.cirrus.com, josh@joshuagrisham.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 8/8] ALSA: hda/realtek: Add mute LED quirk for HP Pavilion x360 14-dy1xxx Date: Mon, 17 Mar 2025 12:39:02 -0400 Message-Id: <20250317163902.1893378-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250317163902.1893378-1-sashal@kernel.org> References: <20250317163902.1893378-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.83 Content-Transfer-Encoding: 8bit From: Navon John Lukose [ Upstream commit b11a74ac4f545626d0dc95a8ca8c41df90532bf3 ] Add a fixup to enable the mute LED on HP Pavilion x360 Convertible 14-dy1xxx with ALC295 codec. The appropriate coefficient index and bits were identified through a brute-force method, as detailed in https://bbs.archlinux.org/viewtopic.php?pid=2079504#p2079504. Signed-off-by: Navon John Lukose Link: https://patch.msgid.link/20250307213319.35507-1-navonjohnlukose@gmail.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_realtek.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index ec57148453c82..29ebcd45233cf 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -4783,6 +4783,21 @@ static void alc236_fixup_hp_coef_micmute_led(struct hda_codec *codec, } } +static void alc295_fixup_hp_mute_led_coefbit11(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + + if (action == HDA_FIXUP_ACT_PRE_PROBE) { + spec->mute_led_polarity = 0; + spec->mute_led_coef.idx = 0xb; + spec->mute_led_coef.mask = 3 << 3; + spec->mute_led_coef.on = 1 << 3; + spec->mute_led_coef.off = 1 << 4; + snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set); + } +} + static void alc285_fixup_hp_mute_led(struct hda_codec *codec, const struct hda_fixup *fix, int action) { @@ -7331,6 +7346,7 @@ enum { ALC290_FIXUP_MONO_SPEAKERS_HSJACK, ALC290_FIXUP_SUBWOOFER, ALC290_FIXUP_SUBWOOFER_HSJACK, + ALC295_FIXUP_HP_MUTE_LED_COEFBIT11, ALC269_FIXUP_THINKPAD_ACPI, ALC269_FIXUP_DMIC_THINKPAD_ACPI, ALC269VB_FIXUP_INFINIX_ZERO_BOOK_13, @@ -9068,6 +9084,10 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC283_FIXUP_INT_MIC, }, + [ALC295_FIXUP_HP_MUTE_LED_COEFBIT11] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc295_fixup_hp_mute_led_coefbit11, + }, [ALC298_FIXUP_SAMSUNG_AMP] = { .type = HDA_FIXUP_FUNC, .v.func = alc298_fixup_samsung_amp, @@ -9976,6 +9996,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), SND_PCI_QUIRK(0x103c, 0x8537, "HP ProBook 440 G6", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c, 0x85c6, "HP Pavilion x360 Convertible 14-dy1xxx", ALC295_FIXUP_HP_MUTE_LED_COEFBIT11), SND_PCI_QUIRK(0x103c, 0x85de, "HP Envy x360 13-ar0xxx", ALC285_FIXUP_HP_ENVY_X360), SND_PCI_QUIRK(0x103c, 0x860f, "HP ZBook 15 G6", ALC285_FIXUP_HP_GPIO_AMP_INIT), SND_PCI_QUIRK(0x103c, 0x861f, "HP Elite Dragonfly G1", ALC285_FIXUP_HP_GPIO_AMP_INIT), -- 2.39.5