From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: [PATCH v2 0/3] Tidy up ASoC control get and put handlers
Date: Wed, 19 Mar 2025 17:51:20 +0000 [thread overview]
Message-ID: <20250319175123.3835849-1-ckeepax@opensource.cirrus.com> (raw)
There is a lot of duplicated and occasionally slightly incorrect code
around the ASoC control get and put handlers. This series add some kunit
tests and then refactors the code to get all the tests passing and
reduce some of the duplication. The focus here is on the volsw handlers,
future work could still be done on some of the others but these were the
ones that most required attention.
Hopefully the only slightly controversal change is the very last patch
which changes platform_max to be applied after the control type is
determined, more discussion in the commit message for that one.
Thanks,
Charles
Changes since v1:
- Drop already applied patches
- Move dropping of a couple of local variables from one patch to
another to avoid a build warning
Charles Keepax (3):
ASoC: ops: Factor out common code from get callbacks
ASoC: ops: Remove some unnecessary local variables
ASoC: ops: Apply platform_max after deciding control type
sound/soc/soc-ops.c | 116 +++++++++++++++++++-------------------------
1 file changed, 49 insertions(+), 67 deletions(-)
--
2.39.5
next reply other threads:[~2025-03-19 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 17:51 Charles Keepax [this message]
2025-03-19 17:51 ` [PATCH v2 1/3] ASoC: ops: Factor out common code from get callbacks Charles Keepax
2025-03-19 17:51 ` [PATCH v2 2/3] ASoC: ops: Remove some unnecessary local variables Charles Keepax
2025-03-19 17:51 ` [PATCH v2 3/3] ASoC: ops: Apply platform_max after deciding control type Charles Keepax
2025-03-20 18:45 ` [PATCH v2 0/3] Tidy up ASoC control get and put handlers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319175123.3835849-1-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox