From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2401F25E817; Mon, 7 Apr 2025 18:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049609; cv=none; b=BjadJF7uOLkOPOSJ1oOSpP76k8D/gIKbRCoKZsK/XfB+6GZeJixj4gMMGorfOEqnIM/S4lr6XlW8Xb9+9OwLiDUrgoVeHRH4oG9a1SEi4I9GZVqTwcgYQQZcTdZ7U0rn0ZrCUAooEwOS8abBFGDCZylSE/w0E7BKZJogUDsaaoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049609; c=relaxed/simple; bh=o66Zs7GApMNs4fUuUIl+NpS0WXNlG3jWsczt+JCtzj4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DKoa35Jjz9iq7kyZ/zpaPH6k44BtZcuNMPb769V7wjtrWUOiPn/Bv9ddnC20OL5Nc4NWr33GOdOKzntwHWyJdyBG5uEirsKnU5U3Ps+z4mde/LsNFbWKZwZoYhqioS3u70x9YH/Mzysy68d945ZvsunhL5mNC7Oyxk3b1Y7ZLRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VGbks3J8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VGbks3J8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECBAAC4CEDD; Mon, 7 Apr 2025 18:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049608; bh=o66Zs7GApMNs4fUuUIl+NpS0WXNlG3jWsczt+JCtzj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VGbks3J88Fd1sikC3KRpvovq8IIMaiwxMJea5XGxRduAoA96FPr1Bm4ACXACuF8zr 1w/Jn3T+1hn0thB2iXuU0m+5nJfem1k5LWRhn0epcSywb69Da1njbGF7GgAJWbo0Id 1tGsENnSAmOZsvbSNrrAgf/6KcRcsSN5rdQhdB5R/qqir3ppBu/94MZWGy2acObZrl bx3gLmaXeC5R5lNauXsa4lwkKSkfn37Y3oEFs8bKdhXyfWGsebVFY0ZbtiTxMgyU1l 8Yzn7h1pLGwJVEkyrOjY/YB3DGDnZpMdehbgh0mPJ8lfiJjYC4a0+AaVk3gdPzRip0 vGzhRo81XC2Wg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Josh Poimboeuf , kernel test robot , Ingo Molnar , Mark Brown , Srinivas Kandagatla , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linus Torvalds , Sasha Levin , nathan@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH AUTOSEL 6.13 26/28] objtool, ASoC: codecs: wcd934x: Remove potential undefined behavior in wcd934x_slim_irq_handler() Date: Mon, 7 Apr 2025 14:12:16 -0400 Message-Id: <20250407181224.3180941-26-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181224.3180941-1-sashal@kernel.org> References: <20250407181224.3180941-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.13.10 Content-Transfer-Encoding: 8bit From: Josh Poimboeuf [ Upstream commit 060aed9c0093b341480770457093449771cf1496 ] If 'port_id' is negative, the shift counts in wcd934x_slim_irq_handler() also become negative, resulting in undefined behavior due to shift out of bounds. If I'm reading the code correctly, that appears to be not possible, but with KCOV enabled, Clang's range analysis isn't always able to determine that and generates undefined behavior. As a result the code generation isn't optimal, and undefined behavior should be avoided regardless. Improve code generation and remove the undefined behavior by converting the signed variables to unsigned. Fixes the following warning with UBSAN: sound/soc/codecs/snd-soc-wcd934x.o: warning: objtool: .text.wcd934x_slim_irq_handler: unexpected end of section Reported-by: kernel test robot Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Acked-by: Mark Brown Cc: Srinivas Kandagatla Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Linus Torvalds Link: https://lore.kernel.org/r/7e863839ec7301bf9c0f429a03873d44e484c31c.1742852847.git.jpoimboe@kernel.org Closes: https://lore.kernel.org/oe-kbuild-all/202503180044.oH9gyPeg-lkp@intel.com/ Signed-off-by: Sasha Levin --- sound/soc/codecs/wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 910852eb9698c..c7f1b28f3b230 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2273,7 +2273,7 @@ static irqreturn_t wcd934x_slim_irq_handler(int irq, void *data) { struct wcd934x_codec *wcd = data; unsigned long status = 0; - int i, j, port_id; + unsigned int i, j, port_id; unsigned int val, int_val = 0; irqreturn_t ret = IRQ_NONE; bool tx; -- 2.39.5