From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C3426A0F3; Mon, 7 Apr 2025 18:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049734; cv=none; b=LP3/ctETp0m+eNqUYQN15Szc5c1zNJGblNvvvMwYWDyHBJmuuKq4WhNYUBCE4XZ+c3IvnNUrhfjlix1BUw1iT61BvOLQgF9uWFIAuwD2gSF3F61C3XDP8Oj2n0m2QRA5qVkVcKw3KXhU14x14cqiNJ1Elh/dn/1oLv2zFuD8gY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744049734; c=relaxed/simple; bh=sqc5/LjtNOxZgdBk9s26ZhlVm1GA5zz7VLoJBbNOe+o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lhYPdjXgv91mRxqB0t/dOUULocRRro+vRFnJFiyfY++aS+68fBicz2S/rbLGsDEVk88ge9sFqWxl8wbMAi3R3cUPRIYnoaYticAmkjO+N/FSBodDGHacA5Qx2DolfgHQK6Iphc8glRAXVGqApoDGZoLjEfFye5KUbqBhgRZ88n0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i7CGsB8A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i7CGsB8A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76231C4CEE7; Mon, 7 Apr 2025 18:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744049734; bh=sqc5/LjtNOxZgdBk9s26ZhlVm1GA5zz7VLoJBbNOe+o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i7CGsB8A4KB68k2Y1DbyFXkYenDTncdoVwDmGHWKBkDs89PLQz7OqsAo5iWi1RQHI SZMuGBmqOqM9idsVfIc8yCrilrLPTa3V74JChgz7YdmVIITLATCCeWmcom7hkdqYDa JU541W1b/g9JZYdl9SFZUOpG47b8IqczmFiBF2/hl4P1z/P0xxjDHXcWaQhFCIB6ZL ttFwrDNINMDS+QMA+YM2ZtSw7xKDOF/VmXiDosQdWD6Iu6xUNfYoHwrU2d6fNNNgWc xr7UF9e/VYzKraRaHIkmSW5sNxf9KEim+/mCzgbEhr/S+vNVo8Fg2HwOwpx4Vi2WoJ DIRWfZ/cY9nwg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Josh Poimboeuf , kernel test robot , Ingo Molnar , Mark Brown , Srinivas Kandagatla , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Linus Torvalds , Sasha Levin , nathan@kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH AUTOSEL 5.15 8/8] objtool, ASoC: codecs: wcd934x: Remove potential undefined behavior in wcd934x_slim_irq_handler() Date: Mon, 7 Apr 2025 14:15:14 -0400 Message-Id: <20250407181516.3183864-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250407181516.3183864-1-sashal@kernel.org> References: <20250407181516.3183864-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.179 Content-Transfer-Encoding: 8bit From: Josh Poimboeuf [ Upstream commit 060aed9c0093b341480770457093449771cf1496 ] If 'port_id' is negative, the shift counts in wcd934x_slim_irq_handler() also become negative, resulting in undefined behavior due to shift out of bounds. If I'm reading the code correctly, that appears to be not possible, but with KCOV enabled, Clang's range analysis isn't always able to determine that and generates undefined behavior. As a result the code generation isn't optimal, and undefined behavior should be avoided regardless. Improve code generation and remove the undefined behavior by converting the signed variables to unsigned. Fixes the following warning with UBSAN: sound/soc/codecs/snd-soc-wcd934x.o: warning: objtool: .text.wcd934x_slim_irq_handler: unexpected end of section Reported-by: kernel test robot Signed-off-by: Josh Poimboeuf Signed-off-by: Ingo Molnar Acked-by: Mark Brown Cc: Srinivas Kandagatla Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Linus Torvalds Link: https://lore.kernel.org/r/7e863839ec7301bf9c0f429a03873d44e484c31c.1742852847.git.jpoimboe@kernel.org Closes: https://lore.kernel.org/oe-kbuild-all/202503180044.oH9gyPeg-lkp@intel.com/ Signed-off-by: Sasha Levin --- sound/soc/codecs/wcd934x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c index 94ffd2ba29aef..765ac2a3e9638 100644 --- a/sound/soc/codecs/wcd934x.c +++ b/sound/soc/codecs/wcd934x.c @@ -2281,7 +2281,7 @@ static irqreturn_t wcd934x_slim_irq_handler(int irq, void *data) { struct wcd934x_codec *wcd = data; unsigned long status = 0; - int i, j, port_id; + unsigned int i, j, port_id; unsigned int val, int_val = 0; irqreturn_t ret = IRQ_NONE; bool tx; -- 2.39.5