From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D283032B9; Sun, 1 Jun 2025 23:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748821022; cv=none; b=kr+YCzXbmBGBGVTxIefY3tbC96p0tJwzRHo7qtGK6Y2SZgPI48Ped0luqa6LZMaVMWZpm+Ya2aPB9BHSByyPg1q95Yz2kktiAmZ6gcSPPNSDgUYW42W0PPH1ZWHoLOIwYSZ5rc+Fe3CXXr992NFqI1L820spr8l1TQeTF37FhCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748821022; c=relaxed/simple; bh=0y9+YK8mVodHzMUpF/xJjqZOSbF0GJFSGAdqCeDpLqw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qSUJ6HtMH8Bsy7t6OI3+6fdFm7AHZ2u2XBgi3kl81oQ9K+M5Ac9mUkg9NpVsrQqdvHH6nJ0qwM9ktIVrOfNe0Sv2FDdZFSgMNrV/PCQC5ZbHzLTbpLh8AtdgkVqr9FrS+FsU6R7Fx6NgWVcJCJSQDHMWuJaPzgAOP/jrUekswL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qmvpe3OU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qmvpe3OU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9329EC4CEE7; Sun, 1 Jun 2025 23:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748821021; bh=0y9+YK8mVodHzMUpF/xJjqZOSbF0GJFSGAdqCeDpLqw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qmvpe3OUWAbLdzyGFEzaq9DAtKypYwe4EYAmvj3w59FJHeeOxqV2p7HgOhGaPM3Gd oTkUhRvpSMngAZexSr5X3n6sl+A08jThEvXUP78ymzR4Swx8UColI0nuTeTLA2yVrH fdRuuvhg918IX4/mXZnaEbADMT9jBnFCjD56pybM+gdNYjpLX5R6muH8b1y6bPRAHc 75sun6mV7MOOUGLhAYoN1kAxFUQwp9fDsu4f1YvzJwytsqOj7AR55SxY6vIpC7EWCP GX6bWri/9SohuR21xZ/jQH8NIILAuvTYxeO9khFYtw74bQTHQ64B7sCAtJy+GEueL4 tl/5laUoXdpVw== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Talhah Peerbhai , Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mario.limonciello@amd.com, venkataprasad.potturu@amd.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH AUTOSEL 6.12 72/93] ASoC: amd: yc: Add quirk for Lenovo Yoga Pro 7 14ASP9 Date: Sun, 1 Jun 2025 19:33:39 -0400 Message-Id: <20250601233402.3512823-72-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250601233402.3512823-1-sashal@kernel.org> References: <20250601233402.3512823-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.31 Content-Transfer-Encoding: 8bit From: Talhah Peerbhai [ Upstream commit a28206060dc5848a1a2a15b7f6ac6223d869084d ] Similar to many other Lenovo models with AMD chips, the Lenovo Yoga Pro 7 14ASP9 (product name 83HN) requires a specific quirk to ensure internal mic detection. This patch adds a quirk fixing this. Signed-off-by: Talhah Peerbhai Link: https://patch.msgid.link/20250515222741.144616-1-talhah.peerbhai@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- Based on my analysis of the commit and comparison with the similar historical commits, here is my assessment: **YES** This commit should be backported to stable kernel trees for the following reasons: ## Code Analysis **1. Nature of the Change:** The commit adds a single quirk entry for the Lenovo Yoga Pro 7 14ASP9 (product name "83HN") to the `yc_acp_quirk_table[]` array in `sound/soc/amd/yc/acp6x-mach.c`. The change is minimal and contained: ```c + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83HN"), + } + }, ``` **2. Meets Stable Tree Criteria:** - **Device ID Addition**: This is explicitly mentioned in the stable kernel rules as acceptable - "It must either fix a real bug that bothers people or just add a device ID" - **Under 100 lines**: The change is only 7 lines with context - **Obviously correct**: The pattern matches exactly what's used for dozens of other Lenovo models - **Fixes real user issue**: Internal microphone non-functionality is a clear hardware regression/bug that affects users **3. Historical Precedent:** All 5 similar commits provided as examples received "Backport Status: YES". They all follow the exact same pattern: - Similar commit subjects mentioning specific Lenovo models - Identical code structure adding DMI quirk entries - Same commit messages describing microphone functionality fixes - Several explicitly included `Cc: stable@vger.kernel.org` tags **4. Risk Assessment:** - **Minimal regression risk**: Adding a quirk entry cannot break existing functionality - **Contained change**: Only affects the specific Lenovo model 83HN - **Well-established pattern**: This quirk mechanism is proven stable across dozens of similar entries **5. User Impact:** The commit message clearly states this fixes internal microphone detection on a specific laptop model. Non-functional audio hardware represents a significant user-facing issue that stable trees are meant to address. **6. Code Quality:** The change also includes a minor whitespace fix (replacing spaces with tab for consistency), showing attention to code quality without introducing functional changes. This commit perfectly matches the stable tree criteria: it's a small, safe device ID addition that fixes a real user- affecting hardware issue with minimal risk of regression. sound/soc/amd/yc/acp6x-mach.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index e632f16c91025..3d9da93d22ee8 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -311,6 +311,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "83AS"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83HN"), + } + }, { .driver_data = &acp6x_card, .matches = { @@ -360,7 +367,7 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M5402RA"), } }, - { + { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), -- 2.39.5