From: Al Viro <viro@zeniv.linux.org.uk>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: mixer_oss: Replace deprecated strcpy() with strscpy()
Date: Wed, 18 Jun 2025 23:49:26 +0100 [thread overview]
Message-ID: <20250618224926.GS1880847@ZenIV> (raw)
In-Reply-To: <20250618223631.1244-2-thorsten.blum@linux.dev>
On Thu, Jun 19, 2025 at 12:36:29AM +0200, Thorsten Blum wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> No functional changes intended.
Have you actually read the damn thing? Seriously, look at the uses
of 'str' downstream. The only thing it is ever passed to is strcmp().
In other words, why do we need to copy it anywhere? What's wrong with
having char *str instead of that array and replacing strcpy() with
plain and simple pointer assignment?
next prev parent reply other threads:[~2025-06-18 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 22:36 [PATCH] ALSA: mixer_oss: Replace deprecated strcpy() with strscpy() Thorsten Blum
2025-06-18 22:49 ` Al Viro [this message]
2025-06-19 12:50 ` Thorsten Blum
2025-06-20 8:08 ` Takashi Iwai
2025-06-23 11:05 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618224926.GS1880847@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox