[PATCH] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv

[PATCH] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv

[Guoqing Jiang]

Given mt8365_dai_set_priv allocate priv_size space to copy priv_data which
means we should pass mt8365_i2s_priv[i] or "struct mtk_afe_i2s_priv" instead
of afe_priv which has the size of "struct mt8365_afe_private".

Otherwise the KASAN complains about.

[   59.389765] BUG: KASAN: global-out-of-bounds in mt8365_dai_set_priv+0xc8/0x168 [snd_soc_mt8365_pcm]
...
[   59.394789] Call trace:
[   59.395167]  dump_backtrace+0xa0/0x128
[   59.395733]  show_stack+0x20/0x38
[   59.396238]  dump_stack_lvl+0xe8/0x148
[   59.396806]  print_report+0x37c/0x5e0
[   59.397358]  kasan_report+0xac/0xf8
[   59.397885]  kasan_check_range+0xe8/0x190
[   59.398485]  asan_memcpy+0x3c/0x98
[   59.399022]  mt8365_dai_set_priv+0xc8/0x168 [snd_soc_mt8365_pcm]
[   59.399928]  mt8365_dai_i2s_register+0x1e8/0x2b0 [snd_soc_mt8365_pcm]
[   59.400893]  mt8365_afe_pcm_dev_probe+0x4d0/0xdf0 [snd_soc_mt8365_pcm]
[   59.401873]  platform_probe+0xcc/0x228
[   59.402442]  really_probe+0x340/0x9e8
[   59.402992]  driver_probe_device+0x16c/0x3f8
[   59.403638]  driver_probe_device+0x64/0x1d8
[   59.404256]  driver_attach+0x1dc/0x4c8
[   59.404840]  bus_for_each_dev+0x100/0x190
[   59.405442]  driver_attach+0x44/0x68
[   59.405980]  bus_add_driver+0x23c/0x500
[   59.406550]  driver_register+0xf8/0x3d0
[   59.407122]  platform_driver_register+0x68/0x98
[   59.407810]  mt8365_afe_pcm_driver_init+0x2c/0xff8 [snd_soc_mt8365_pcm]

Fixes: 402bbb13a195 ("ASoC: mediatek: mt8365: Add I2S DAI support")
Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
---
 sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
index cae51756cead..fbdc01e954c2 100644
--- a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
+++ b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
@@ -812,11 +812,10 @@ static const struct snd_soc_dapm_route mtk_dai_i2s_routes[] = {
 static int mt8365_dai_i2s_set_priv(struct mtk_base_afe *afe)
 {
 	int i, ret;
-	struct mt8365_afe_private *afe_priv = afe->platform_priv;
 
 	for (i = 0; i < DAI_I2S_NUM; i++) {
 		ret = mt8365_dai_set_priv(afe, mt8365_i2s_priv[i].id,
-					  sizeof(*afe_priv),
+					  sizeof(mt8365_i2s_priv[i])
 					  &mt8365_i2s_priv[i]);
 		if (ret)
 			return ret;
-- 
2.35.3

Re: [PATCH] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv

[kernel test robot]

Hi Guoqing,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on broonie-spi/for-next tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.16-rc5 next-20250709]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guoqing-Jiang/ASoC-mediatek-mt8365-dai-i2s-pass-correct-size-to-mt8365_dai_set_priv/20250709-134028
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20250709053900.55171-1-guoqing.jiang%40canonical.com
patch subject: [PATCH] ASoC: mediatek: mt8365-dai-i2s: pass correct size to mt8365_dai_set_priv
config: csky-randconfig-001-20250709 (https://download.01.org/0day-ci/archive/20250710/202507100010.qEVMavru-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250710/202507100010.qEVMavru-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507100010.qEVMavru-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/soc/mediatek/mt8365/mt8365-dai-i2s.c: In function 'mt8365_dai_i2s_set_priv':
>> sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:819:43: error: invalid operands to binary & (have 'unsigned int' and 'struct mtk_afe_i2s_priv')
     819 |                                           &mt8365_i2s_priv[i]);
         |                                           ^~~~~~~~~~~~~~~~~~~
         |                                                           |
         |                                                           struct mtk_afe_i2s_priv
>> sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:817:23: error: too few arguments to function 'mt8365_dai_set_priv'; expected 4, have 3
     817 |                 ret = mt8365_dai_set_priv(afe, mt8365_i2s_priv[i].id,
         |                       ^~~~~~~~~~~~~~~~~~~
   In file included from sound/soc/mediatek/mt8365/mt8365-dai-i2s.c:14:
   sound/soc/mediatek/mt8365/mt8365-afe-common.h:428:5: note: declared here
     428 | int mt8365_dai_set_priv(struct mtk_base_afe *afe,
         |     ^~~~~~~~~~~~~~~~~~~


vim +819 sound/soc/mediatek/mt8365/mt8365-dai-i2s.c

402bbb13a195ca Alexandre Mergnat 2024-07-22  811  
402bbb13a195ca Alexandre Mergnat 2024-07-22  812  static int mt8365_dai_i2s_set_priv(struct mtk_base_afe *afe)
402bbb13a195ca Alexandre Mergnat 2024-07-22  813  {
402bbb13a195ca Alexandre Mergnat 2024-07-22  814  	int i, ret;
402bbb13a195ca Alexandre Mergnat 2024-07-22  815  
402bbb13a195ca Alexandre Mergnat 2024-07-22  816  	for (i = 0; i < DAI_I2S_NUM; i++) {
402bbb13a195ca Alexandre Mergnat 2024-07-22 @817  		ret = mt8365_dai_set_priv(afe, mt8365_i2s_priv[i].id,
08cb0e42ff0631 Guoqing Jiang     2025-07-09  818  					  sizeof(mt8365_i2s_priv[i])
402bbb13a195ca Alexandre Mergnat 2024-07-22 @819  					  &mt8365_i2s_priv[i]);
402bbb13a195ca Alexandre Mergnat 2024-07-22  820  		if (ret)
402bbb13a195ca Alexandre Mergnat 2024-07-22  821  			return ret;
402bbb13a195ca Alexandre Mergnat 2024-07-22  822  	}
402bbb13a195ca Alexandre Mergnat 2024-07-22  823  	return 0;
402bbb13a195ca Alexandre Mergnat 2024-07-22  824  }
402bbb13a195ca Alexandre Mergnat 2024-07-22  825  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki