Re: [RFC PATCH v3] ALSA: usb-audio: Add support for TASCAM US-144MKII

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Aug 03, 2025 at 10:34:09PM +0200, Šerif Rami wrote:
> +/**
> + * driver_version_show() - Sysfs attribute to display the driver version.
> + * @dev: Pointer to the device structure.
> + * @attr: Pointer to the device attribute structure.
> + * @buf: Buffer to write the version string into.
> + *
> + * This function is a sysfs callback that provides the current driver version
> + * string to user-space when the 'driver_version' attribute is read.
> + *
> + * Return: The number of bytes written to the buffer.
> + */
> +static ssize_t driver_version_show(struct device *dev,
> +				   struct device_attribute *attr, char *buf)
> +{
> +	return sysfs_emit(buf, "%s\n", DRIVER_VERSION);
> +}
> +static DEVICE_ATTR_RO(driver_version);

The driver version makes no sense when it is in the kernel tree, so this
can be removed.

Also, all sysfs files need to be documented in Documentation/ABI/

thanks,

greg k-h