From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: tiwai@suse.com, perex@perex.cz,
amadeuszx.slawinski@linux.intel.com, nathan@kernel.org,
linux-sound@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH 10/17] ASoC: Intel: avs: probe: Refactor dai_link creation
Date: Tue, 2 Sep 2025 11:48:46 +0200 [thread overview]
Message-ID: <20250902094853.1231842-11-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20250902094853.1231842-1-cezary.rojewski@intel.com>
To allow for multiple instances of the card, move away from static
dai_link declaration.
While at it, simplify the code as the name of the platform component
matches the name of the card's platform_device:
- drop mach->mach_params.platform usage
- drop snd_soc_fixup_dai_links_platform_name() usage
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/avs/boards/probe.c | 53 +++++++++++++++++-------------
1 file changed, 31 insertions(+), 22 deletions(-)
diff --git a/sound/soc/intel/avs/boards/probe.c b/sound/soc/intel/avs/boards/probe.c
index 06c1f19f27aa..73884f8a535c 100644
--- a/sound/soc/intel/avs/boards/probe.c
+++ b/sound/soc/intel/avs/boards/probe.c
@@ -9,45 +9,54 @@
#include <linux/device.h>
#include <linux/module.h>
#include <sound/soc.h>
-#include <sound/soc-acpi.h>
-
-SND_SOC_DAILINK_DEF(dummy, DAILINK_COMP_ARRAY(COMP_DUMMY()));
-SND_SOC_DAILINK_DEF(probe_cp, DAILINK_COMP_ARRAY(COMP_CPU("Probe Extraction CPU DAI")));
-SND_SOC_DAILINK_DEF(platform, DAILINK_COMP_ARRAY(COMP_PLATFORM("probe-platform")));
-
-static struct snd_soc_dai_link probe_mb_dai_links[] = {
- {
- .name = "Compress Probe Capture",
- .nonatomic = 1,
- SND_SOC_DAILINK_REG(probe_cp, dummy, platform),
- },
-};
+
+static int avs_create_dai_links(struct device *dev, struct snd_soc_dai_link **links, int *num_links)
+{
+ struct snd_soc_dai_link *dl;
+
+ dl = devm_kzalloc(dev, sizeof(*dl), GFP_KERNEL);
+ if (!dl)
+ return -ENOMEM;
+
+ dl->cpus = devm_kzalloc(dev, sizeof(*dl->cpus), GFP_KERNEL);
+ dl->platforms = devm_kzalloc(dev, sizeof(*dl->platforms), GFP_KERNEL);
+ if (!dl->cpus || !dl->platforms)
+ return -ENOMEM;
+
+ dl->name = "Compress Probe Capture";
+ dl->cpus->dai_name = "Probe Extraction CPU DAI";
+ dl->num_cpus = 1;
+ dl->codecs = &snd_soc_dummy_dlc;
+ dl->num_codecs = 1;
+ dl->platforms->name = dev_name(dev);
+ dl->num_platforms = 1;
+ dl->nonatomic = 1;
+
+ *links = dl;
+ *num_links = 1;
+ return 0;
+}
static int avs_probe_mb_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct snd_soc_acpi_mach *mach;
struct snd_soc_card *card;
int ret;
- mach = dev_get_platdata(dev);
-
card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
if (!card)
return -ENOMEM;
+ ret = avs_create_dai_links(dev, &card->dai_link, &card->num_links);
+ if (ret)
+ return ret;
+
card->driver_name = "avs_probe_mb";
card->long_name = card->name = "AVS PROBE";
card->dev = dev;
card->owner = THIS_MODULE;
- card->dai_link = probe_mb_dai_links;
- card->num_links = ARRAY_SIZE(probe_mb_dai_links);
card->fully_routed = true;
- ret = snd_soc_fixup_dai_links_platform_name(card, mach->mach_params.platform);
- if (ret)
- return ret;
-
return devm_snd_soc_register_deferrable_card(dev, card);
}
--
2.25.1
next prev parent reply other threads:[~2025-09-02 9:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 9:48 [PATCH 00/17] ASoC: Intel: avs: Adjust platform names Cezary Rojewski
2025-09-02 9:48 ` [PATCH 01/17] ASoC: Intel: avs: hda: Adjust platform name Cezary Rojewski
2025-09-02 9:48 ` [PATCH 02/17] ASoC: Intel: avs: da7219: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 03/17] ASoC: Intel: avs: dmic: Refactor dai_link creation Cezary Rojewski
2025-09-02 9:48 ` [PATCH 04/17] ASoC: Intel: avs: es8336: Adjust platform name Cezary Rojewski
2025-09-02 9:48 ` [PATCH 05/17] ASoC: Intel: avs: i2stest: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 06/17] ASoC: Intel: avs: max98357a: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 07/17] ASoC: Intel: avs: max98373: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 08/17] ASoC: Intel: avs: max98927: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 09/17] ASoC: Intel: avs: nau8825: " Cezary Rojewski
2025-09-02 9:48 ` Cezary Rojewski [this message]
2025-09-02 9:48 ` [PATCH 11/17] ASoC: Intel: avs: rt274: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 12/17] ASoC: Intel: avs: rt286: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 13/17] ASoC: Intel: avs: rt298: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 14/17] ASoC: Intel: avs: rt5514: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 15/17] ASoC: Intel: avs: rt5663: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 16/17] ASoC: Intel: avs: rt5682: " Cezary Rojewski
2025-09-02 9:48 ` [PATCH 17/17] ASoC: Intel: avs: ssm4567: " Cezary Rojewski
2025-09-02 21:20 ` [PATCH 00/17] ASoC: Intel: avs: Adjust platform names Nathan Chancellor
2025-09-03 10:58 ` Mark Brown
2025-09-03 11:02 ` Amadeusz Sławiński
2025-09-03 18:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902094853.1231842-11-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox