Re: [PATCH 12/21] mfd: arizona: make legacy gpiolib interface optional

[Lee Jones <lee@kernel.org>]

On Tue, 02 Sep 2025, Arnd Bergmann wrote:

> On Tue, Sep 2, 2025, at 14:44, Lee Jones wrote:
> > On Fri, 08 Aug 2025, Arnd Bergmann wrote:
> >
> >> From: Arnd Bergmann <arnd@arndb.de>
> >> 
> >> The only machine that still uses the old gpio number based interface
> >> is the wlf_cragg_6410 board file. In order to remove the dependency
> >> on the interfaces, add #ifdef blocks here.
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> ---
> >>  drivers/mfd/arizona-irq.c         |  5 ++++-
> >>  include/linux/mfd/arizona/pdata.h |  6 ++++++
> >>  sound/soc/codecs/arizona-jack.c   | 17 ++++++++++++++++-
> >>  3 files changed, 26 insertions(+), 2 deletions(-)
> >
> > Just FTR, I hate this!   =:-D
> 
> Any alternative suggestions?
> 
> Would you be happier with a hard "depends on GPIOLIB_LEGACY"?
> 
> I see only two in-tree users other than the old 6410 board
> that use the modern path: exynos5433-tm2-common.dtsi
> and drivers/platform/x86/x86-android-tablets/lenovo.c.
> 
> Making those platforms 'select GPIOLIB_LEGACY' is technically
> incorrect since they don't need the legayc interfaces, but it
> would be a temporary workaround until wlf_cragg_6410 is
> gone.

I've applied the patches for now in the hope that these can get cleaned
away at one point.

-- 
Lee Jones [李琼斯]