From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A230B306484 for ; Fri, 5 Sep 2025 09:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757063430; cv=none; b=F1mI3R3fVA9GB569XsmWzCuW1SI4mDn19sZZIaqP7hc5ToLh4Vp4Vu7tH+qvawblmvp4rzVmQD/0i84RUDBk9Tb+Pa2xMPrCqCqFrTSj33q4NqpPqV125yR5fzVf1IF57jvFRIKyhDS3vY1pUXhf6Ur0TNl+RQk/8b8P1Nw24ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757063430; c=relaxed/simple; bh=INrPsOaDPOgTfeCDARaJthcf6XrpCVFPdMENM7Zss0M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=itbRhEZ7U+poebARlr0PNSkE35MAp1+HIN+8KFfkJwIKil9bn/vWdi2pXvLhWErhQFA9iqmUQcBns8fhRpUalldpNoOclY7a5RguBprT0UggAgvbXFybt6n+trevWhrG3wOhb9RDfyUQu0iQPlwdo4fItD8vXm81B9QxYxeEjew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KJOJ+Xe2; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KJOJ+Xe2" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45b869d3571so6600535e9.1 for ; Fri, 05 Sep 2025 02:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1757063427; x=1757668227; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dpdupnX4vfe35A0YWfmfZS06mTiUiX4f85kgJALe7OA=; b=KJOJ+Xe2mjmb7bAprSD+QvNniNx6LJpQAws3oMdOOlS31JRYJFQ3RO3FIDZIGn9Qkx 3mlQlMu9bOdBi4pGIkJoTCv1jjGBzHQE/GkjN9iXjEsNWq/Hh6wTRRhJb0HTCeNuzGSD +91cjb7fZ8/WVvB35UT5bQJst7kbHe59GqWtUZIBJqNVOEiICNX5vU7wdWTorrwqctjE h/7aD4SQmM5SSXAacg1eEXDV56AVGxpzQMGroDIMNDn7uu/lX/3gqWs1hBxJHQlIfYxl teRQ8ZTE2Bkqc454aXgumw6iZ5EF2xhJ5cIrbGdQZJfYZm38FiqRYxZnI6TRXJ3o4ASv ln2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757063427; x=1757668227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dpdupnX4vfe35A0YWfmfZS06mTiUiX4f85kgJALe7OA=; b=JcoOGv8m3IqH4PcghfsQaYu/160K6z+mKapJrPkZy8ma+0TRH87R/TsIDesdzSZNyU bvYI1+Jvm+nFFHrkB99LSvaxMyZNboE0z5AJez2xgM+HfWKQMUkv3mJm18o7qymuqfCh VYWNPLTIvbBsNYHJJI4zGZAyJOqBuTKc0fKSUx+5iolztZkq7lGwn9FXYgZ4U21Me9P3 Mwyh70HkvEQZzyqvcfPtyCwbmUQ+d+X49u1+i6DzSRWCjJwwo56U6hCUQAks2HeFGBOZ CTHp54F7gYQW5OTDyTVjoVH7qjJZl2Huo5WwcNBaf7cIRS5ujP8pJo4R98vuIaxFPdOX JppA== X-Forwarded-Encrypted: i=1; AJvYcCW+qWqgMvCiKwARxjroFXJT32H676AkJNLy5nDtpHQfs/TSCkD1Z486kxUG6mYYFcMkrml9ShrluU1k9A==@vger.kernel.org X-Gm-Message-State: AOJu0YxWXkatXtLyk2cMGsKqKSzAbYYa07k1jT714mPWcO9ORJA5fJpa O+xISSziMtbc1ynMuFO9+t44f2TMz5+9Pv4aldJyP+OcWW0WF/JkBUL/qFNafAY/ypzXnD2FGFq b6JyFeRc= X-Gm-Gg: ASbGnctsDA9q4soEPl7N5hVeGPx2BjwT2rLrX5fJLCTT5s8CVT7fl3aVMm71up3byA5 pyA567iPMa6RGVdJw+m/QF48MU5d2ub0B4tN4/huiBOdqu5f1zn1/3swYUHlz+hg1eMngc6it7Y lYX1oOLe0+N3Gn4JYfkPMKkHvST+SieWRzrIkCzVywC0Z5tjkSD2CxTvkDcosTys2ZqJXaMrzEQ ZTXuPcalQQynurCf6I6CyORZlQJuOO+Y1/qgzP1ekWDArQDwM36P+C2h8OSyA9GZow4zz2T94iK Pe/KFtvUhUcB2NOWy3lBRi/cM/EjGiB4B+wzeeJhJNgs0//gK3BKkJmQv/y6Hi2mt0rn0VWVMEN dg9CPPpbUKSiUgx5SfKmdxGQLz5Rh+Mmv28Q6KJr3OpwXn14= X-Google-Smtp-Source: AGHT+IFr+TiMT2uI2Q2nJdE3JgvgpnzZ9ukTZzZnhJP/XpcOI3yrffJHsD8X/7zkbTldBeHaxM0ymA== X-Received: by 2002:a05:600c:4fcd:b0:456:19eb:2e09 with SMTP id 5b1f17b1804b1-45b85528589mr202725185e9.8.1757063427034; Fri, 05 Sep 2025 02:10:27 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45dd4affb6bsm39726915e9.1.2025.09.05.02.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 02:10:26 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: [PATCH 0/2] sound: soc: replace wq users and add WQ_PERCPU to alloc_workqueue() users Date: Fri, 5 Sep 2025 11:10:14 +0200 Message-ID: <20250905091016.109428-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi! Below is a summary of a discussion about the Workqueue API and cpu isolation considerations. Details and more information are available here: "workqueue: Always use wq_select_unbound_cpu() for WORK_CPU_UNBOUND." https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/ === Current situation: problems === Let's consider a nohz_full system with isolated CPUs: wq_unbound_cpumask is set to the housekeeping CPUs, for !WQ_UNBOUND the local CPU is selected. This leads to different scenarios if a work item is scheduled on an isolated CPU where "delay" value is 0 or greater then 0: schedule_delayed_work(, 0); This will be handled by __queue_work() that will queue the work item on the current local (isolated) CPU, while: schedule_delayed_work(, 1); Will move the timer on an housekeeping CPU, and schedule the work there. Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. === Plan and future plans === This patchset is the first stone on a refactoring needed in order to address the points aforementioned; it will have a positive impact also on the cpu isolation, in the long term, moving away percpu workqueue in favor to an unbound model. These are the main steps: 1) API refactoring (that this patch is introducing) - Make more clear and uniform the system wq names, both per-cpu and unbound. This to avoid any possible confusion on what should be used. - Introduction of WQ_PERCPU: this flag is the complement of WQ_UNBOUND, introduced in this patchset and used on all the callers that are not currently using WQ_UNBOUND. WQ_UNBOUND will be removed in a future release cycle. Most users don't need to be per-cpu, because they don't have locality requirements, because of that, a next future step will be make "unbound" the default behavior. 2) Check who really needs to be per-cpu - Remove the WQ_PERCPU flag when is not strictly required. 3) Add a new API (prefer local cpu) - There are users that don't require a local execution, like mentioned above; despite that, local execution yeld to performance gain. This new API will prefer the local execution, without requiring it. === Introduced Changes by this series === 1) [P 1-2] Replace use of system_wq and system_unbound_wq system_wq is a per-CPU workqueue, but his name is not clear. system_unbound_wq is to be used when locality is not required. Because of that, system_wq has been renamed in system_percpu_wq, and system_unbound_wq has been renamed in system_dfl_wq. === For Maintainers === There are prerequisites for this series, already merged in the master branch. The commits are: 128ea9f6ccfb6960293ae4212f4f97165e42222d ("workqueue: Add system_percpu_wq and system_dfl_wq") 930c2ea566aff59e962c50b2421d5fcc3b98b8be ("workqueue: Add new WQ_PERCPU flag") Thanks! Marco Crivellari (2): ASoC: replace use of system_unbound_wq with system_dfl_wq ASoC: replace use of system_wq with system_percpu_wq sound/soc/codecs/aw88081.c | 2 +- sound/soc/codecs/aw88166.c | 2 +- sound/soc/codecs/aw88261.c | 2 +- sound/soc/codecs/aw88395/aw88395.c | 2 +- sound/soc/codecs/aw88399.c | 2 +- sound/soc/codecs/cs42l43-jack.c | 6 +++--- sound/soc/codecs/cs42l43.c | 4 ++-- sound/soc/codecs/es8326.c | 12 ++++++------ sound/soc/codecs/rt5663.c | 6 +++--- sound/soc/codecs/wm_adsp.c | 2 +- sound/soc/intel/boards/sof_es8336.c | 2 +- sound/soc/sof/intel/cnl.c | 2 +- sound/soc/sof/intel/hda-ipc.c | 2 +- 13 files changed, 23 insertions(+), 23 deletions(-) -- 2.51.0