Linux Sound subsystem development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
	broonie@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, lgirdwood@gmail.com,
	tiwai@suse.com, vkoul@kernel.org,
	yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
	srini@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v4 07/13] ASoC: codecs: wcd: add common helper for wcd codecs
Date: Mon, 8 Sep 2025 18:40:36 +0800	[thread overview]
Message-ID: <202509081839.R4vv3FST-lkp@intel.com> (raw)
In-Reply-To: <20250907112201.259405-8-srinivas.kandagatla@oss.qualcomm.com>

Hi Srinivas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.17-rc5 next-20250905]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivas-Kandagatla/ASoC-codecs-wcd937x-set-the-comp-soundwire-port-correctly/20250907-192533
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20250907112201.259405-8-srinivas.kandagatla%40oss.qualcomm.com
patch subject: [PATCH v4 07/13] ASoC: codecs: wcd: add common helper for wcd codecs
config: openrisc-allyesconfig (https://download.01.org/0day-ci/archive/20250908/202509081839.R4vv3FST-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250908/202509081839.R4vv3FST-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509081839.R4vv3FST-lkp@intel.com/

All warnings (new ones prefixed by >>):

   sound/soc/codecs/wcd-common.c: In function 'wcd_dt_parse_micbias_info':
>> sound/soc/codecs/wcd-common.c:34:51: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=]
      34 |         sprintf(micbias, "qcom,micbias%d-microvolt", micb_num);
         |                                                   ^
   In function 'wcd_get_micbias_val',
       inlined from 'wcd_dt_parse_micbias_info' at sound/soc/codecs/wcd-common.c:61:26:
   sound/soc/codecs/wcd-common.c:34:9: note: 'sprintf' output between 24 and 33 bytes into a destination of size 32
      34 |         sprintf(micbias, "qcom,micbias%d-microvolt", micb_num);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/sprintf +34 sound/soc/codecs/wcd-common.c

    28	
    29	static int wcd_get_micbias_val(struct device *dev, int micb_num, u32 *micb_mv)
    30	{
    31		char micbias[32];
    32		int mv;
    33	
  > 34		sprintf(micbias, "qcom,micbias%d-microvolt", micb_num);
    35	
    36		if (of_property_read_u32(dev->of_node, micbias, &mv)) {
    37			dev_err(dev, "%s value not found, using default\n", micbias);
    38			mv = WCD_DEF_MICBIAS_MV;
    39		} else {
    40			/* convert it to milli volts */
    41			mv = mv/1000;
    42		}
    43		if (micb_mv)
    44			*micb_mv = mv;
    45	
    46		mv = wcd_get_micb_vout_ctl_val(dev, mv);
    47		if (mv < 0) {
    48			dev_err(dev, "Unsupported %s voltage (%d mV), falling back to default (%d mV)\n",
    49					micbias, mv, WCD_DEF_MICBIAS_MV);
    50			return wcd_get_micb_vout_ctl_val(dev, WCD_DEF_MICBIAS_MV);
    51		}
    52	
    53		return mv;
    54	}
    55	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-09-08 10:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07 11:21 [PATCH v4 00/13] ASoC: codecs: wcd93xxx: remove code duplication Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 01/13] ASoC: codecs: wcd937x: set the comp soundwire port correctly Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 02/13] ASoC: codecs: wcd937x: make stub functions inline Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 03/13] soundwire: bus: add of_sdw_find_device_by_node helper Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 04/13] soundwire: bus: add sdw_slave_get_current_bank helper Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 05/13] ASoC: codecs: wcdxxxx: use of_sdw_find_device_by_node helper Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 06/13] ASoC: codecs: wcdxxxx: use sdw_slave_get_current_bank helper Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 07/13] ASoC: codecs: wcd: add common helper for wcd codecs Srinivas Kandagatla
2025-09-08 10:40   ` kernel test robot [this message]
2025-09-09 12:12     ` Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 08/13] ASoC: codecs: wcd-common: move WCD_SDW_CH to common Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 09/13] ASoC: codecs: wcd-common: move component ops " Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 10/13] ASoC: codecs: wcd939x: get regmap directly Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 11/13] ASoC: codecs: wcd-common: move status_update callback to common Srinivas Kandagatla
2025-09-07 11:21 ` [PATCH v4 12/13] ASoC: codecs: wcd938x: get regmap directly Srinivas Kandagatla
2025-09-07 11:22 ` [PATCH v4 13/13] ASoC: codecs: wcd937x: " Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202509081839.R4vv3FST-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=srini@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox