From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 818D51AA7BF for ; Sat, 27 Sep 2025 15:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758988259; cv=none; b=N4Dfa8C5cZ1pbzZqTnMezAbN/QJkd/bMmKaGOVHMckAH0ECwldLFVvNAc46wGqyrYf3qFe6Po6+BDdb9OC7cvuqnwgZ82gBdSpFI+/PrBZrS4U569AyQt6EQWLlOTeGZF6murPFY2eQkLgnqMIwxIKt1iOT5uYismTha7tpvFj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758988259; c=relaxed/simple; bh=nNKWPuJkQvdYn2ghVo9TRkfN7u3Hidr2mJ7omivL/CU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bEkQBuBDOpglLgrqC33gTz2VXYz4d7wA39CbxcTY9wsD3QhSc5b2dwhi6Jv8cDGxtv7OM+ySMvfUiQku/LtiaAD2FzlTDaZiAgEM+dpkVtL8R5z1l0dE2PgDSICDP43FCQjp3Qv9QodHlslA2AsHqz1R2Dx0R5ZzJW9xQ6iRULY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qmat1un8; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qmat1un8" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-782a77b5ec7so111106b3a.1 for ; Sat, 27 Sep 2025 08:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758988258; x=1759593058; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6kgj5+aCbR7yqP5SrP2a81oiXtc58AxAfkdpFxIVr5E=; b=Qmat1un8cY4JDHOtk1A4nR3vox+KoM+S+KWts2E8RdBC4gsU7Y94YKS3ZYlto3kAIr gOTZQuRusIWRgG81lxLY3ZNd0IiMTCHzJqQuB0AV2U2N5nnmD2oc6E5+qcDQrOtI8yWT 1+gEiUdqIriR0dpCtc+T9atMRZwcIQqqfnIaCYTc91J+/E7JZlnsdj69MbTccjb9FoVx fQk7sycLclNz+BliTU5uD3Tg3luo+QF7FmkVHmMKMOd26Al9/SStS3mgIHPablu1wJUt +sA70VYPmcIvIJRhSQznb76hKv1SwoivyGQjnQhXYSEi37P+q0KnROkzEEOuuUXR1Zwj 6CtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758988258; x=1759593058; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6kgj5+aCbR7yqP5SrP2a81oiXtc58AxAfkdpFxIVr5E=; b=xPc0aCwuytOKflBZ/w+vdzLD8rGJPNtTd6Q7qu1Z2OyqFoYsJHHWWEpfQZnRvV2dK9 tKKabP4IzsESR+drHkGTmQLhZE5uD1TpIAl3zTy9aQ7SnRRK7OqscEmTlcp6ZyoK6bH+ hzCUGrGYZsZdBpZ9snRrlchhXGiPhvOcPLbpwU0mdimraLOD+bzjnW9u4P1Gxn78wv7b mGCYqcEf6JvenX/TqnDzK4Vd9jYZZr5ZK3mL2NzUm4/ddWsU6k8g1khUCiyV/tgY0VJz TZCv/r3USP7vCCQ1DtmdT9covMMNoTNRkZWdYRnvCsFdPBCwYY8Pu+ArBpU57rrtZzQX CI1A== X-Forwarded-Encrypted: i=1; AJvYcCVzV/7LFoGM/hXAFEst7/KD+fraeORKr7iZAo3DJdbpx4/LKUHbrFKzRws5xZpPcgspDRp1ziAWFlNxpw==@vger.kernel.org X-Gm-Message-State: AOJu0YxbPUbGd002o6S7Wg3p0U0RiMw3RO96czllFglyJCgMIyJ4jxlG faTAG8gqNLItvPrUD5rLqWDgr30WdFw64GC1OI5xOzYVJsHinX+I6EuFXBbouaN6 X-Gm-Gg: ASbGnctezrzwsQti25+5v88TewxJ1qbOLzOs8X7YSxHmBbO24Ph6BKvA1kklXobQ6r7 JEeWOsN9q2xnAtQfaBPDOh8H3+yICK4U0naTY5fIlvVl+30BUEGMC/5TNUMeb34dfCYvEZqdn0G uzMUlKrIsjwReJtl14DOu05hVGEQubQmrnnHIL6yODrGTiHhdqhDSc1XIv/OsnwHAO6ErrleNwG hwWyn8NjDwUYgr2w/FvvPxuSyoLwQIuqGNue6DqGOn4Fdgaj+UNo3rOCgtirgWhCzvl8FUxwbIm yPSy/B4nS04pctS1SfGZTK9QfVDBSBQrXAJhLm6rBRvZYQg3iZbbRPl1Mu4yGPSERg+1U9blxyw 9Ej6vEJoW8i9dlJmuuXB0mUk6vYFH4GO+QQyY52AA9FaF4S5xmg== X-Google-Smtp-Source: AGHT+IG47ud1lSXpr6ExC0WiuaHug4JfaaJhlS0FN8NZqk0SCfXpPQQk/wLHxYqFM8SzjzqvDy4OmQ== X-Received: by 2002:a05:6a21:3391:b0:246:458:8540 with SMTP id adf61e73a8af0-2e7bfc1d510mr14582568637.1.1758988257816; Sat, 27 Sep 2025 08:50:57 -0700 (PDT) Received: from name2965-Precision-7820-Tower.. ([121.185.186.233]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b57c53db8e3sm7290750a12.23.2025.09.27.08.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Sep 2025 08:50:57 -0700 (PDT) From: Jeongjun Park To: syzbot+f02665daa2abeef4a947@syzkaller.appspotmail.com Cc: aha310510@gmail.com, clemens@ladisch.de, hdanton@sina.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, perex@perex.cz, syzkaller-bugs@googlegroups.com, tiwai@suse.de Subject: Re: [syzbot] [sound?] [usb?] general protection fault in snd_usbmidi_do_output Date: Sun, 28 Sep 2025 00:50:52 +0900 Message-Id: <20250927155052.880528-1-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <68d7f4e9.a00a0220.102ee.0017.GAE@google.com> References: <68d7f4e9.a00a0220.102ee.0017.GAE@google.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit syzbot wrote: > > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger any issue: > > Reported-by: syzbot+f02665daa2abeef4a947@syzkaller.appspotmail.com > Tested-by: syzbot+f02665daa2abeef4a947@syzkaller.appspotmail.com > > Tested on: > #syz test upstream master --- sound/usb/midi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index acb3bf92857c..97e7e7662b12 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -1522,15 +1522,14 @@ static void snd_usbmidi_free(struct snd_usb_midi *umidi) { int i; + if (!umidi->disconnected) + snd_usbmidi_disconnect(&umidi->list); + for (i = 0; i < MIDI_MAX_ENDPOINTS; ++i) { struct snd_usb_midi_endpoint *ep = &umidi->endpoints[i]; - if (ep->out) - snd_usbmidi_out_endpoint_delete(ep->out); - if (ep->in) - snd_usbmidi_in_endpoint_delete(ep->in); + kfree(ep->out); } mutex_destroy(&umidi->mutex); - timer_shutdown_sync(&umidi->error_timer); kfree(umidi); } --