From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01BC3C2E0 for ; Tue, 7 Oct 2025 16:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759852819; cv=none; b=n7yiY3tKrsnPgJ0n6aYTzSZg4R8r5DD/RVyYvUYxxsJUVxj+IPgDCjwoqRHiCTM2DMFdOmBK/baqqdT7siYdZXvVIH1nxuI1x4yz+8tI1Ptq8FypK3JJ0KPJD8Y/lbKSjN5NpVbjsGo/q410Ft55XwQKuDZBbGWUoSh4+4u2Rqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759852819; c=relaxed/simple; bh=tOuaE0yzBvzmDNmWiObqpdAyTNJjwYPBrd8+TZV3+Ko=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XitfAlsTxXX1HGBArp+JPsFmrKU7sF0NETts578vbzXGJlzFzvS8+F6vIgvnGG2Nq5qzutf1gPjR+2IkVoS2mXnd/F9i7D+2rW2ctFlQUWBNjN2vxa0Y7laBQ9On2KTt8aTey7tBkc2COk6CFdTDEc+UXEqsJ9WhRSY1WPMm50w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j2SmfgKB; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j2SmfgKB" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-b60971c17acso5628201a12.3 for ; Tue, 07 Oct 2025 09:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759852817; x=1760457617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lUu2Hbw6HPA09/pxIefcvSfqvI47HFpD83KFx9cFtbk=; b=j2SmfgKB5iDmWmDue0DVxhAS7BEawG7V1vQJZhEBct4yMlBluubrYuMwTYgssWvftz whrDnMuPlIs1hWamgtcprSQEGa+YhMvO8C3CUqYjKJX2/tW771aQsUFHoDZJ4pQQyntj TtB8IyPFnKfSfBrzczSMK2pWSSaolfDdPTyfSmT2NEWf+gxR6xoML289OQV5S2F/zGq9 B9RfzNLC1LWnG3oYisP2MHezLa0FqSw5RwnGGkI4ILZvGFCeT5bRqHfkqXcPAzC6b9wn z4eI43ewBuAVvFYtkcb3d483jqobLzM9gd0j3uqL2C76jtNFrpr+pg1WYDcEusf+z9gv WWEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759852817; x=1760457617; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lUu2Hbw6HPA09/pxIefcvSfqvI47HFpD83KFx9cFtbk=; b=WkfcbSYYFlj6EvsGjBPVVr8v2ul8NhuRVaT3ywc6XNA1SRDXnmGGjIc2ZDX56w6KZg lFPVp5anYw9+YdfRT6VaJDDa676Z10/IfiV01Zc/htGJJXxHNqyf8CfbLY0982oQq0I/ ECxy3O+mrwQJ6Bfj+RAUtaX9RyOv2ctYq1ws6IwppsdAyHc88SR0WJ2wARyMmkJcG4wH 7gHaVFGsx3AYJ40Z+L29QtulLFYiXyw6DfWh/3TFeRbBKPyd0tZO+zI66g65eEOpM9Lu EhtyrG7Do/MumATeAxECBY594a6TK7VVGuNgVDKUCzzQtVJ6HxBqhE4ycd3OOee5/f7y o7xQ== X-Forwarded-Encrypted: i=1; AJvYcCUMXWXjlph+FM8O1t+N/9JemvOPGaK6JVkBqsi28eH0XcoCsgmkx2O7j7DllXigcUkotSwt62YLoClWKg==@vger.kernel.org X-Gm-Message-State: AOJu0YzOZX5PJenaPXN5J6+8+3TSP05tYPaqccdPFa8Y8SrQJOvcVvza x3hp4OBJphdhXThKGREkUpDeikXRknZrg/10s5YwC44VGq08VA1q0HlP X-Gm-Gg: ASbGncsPpSfvc2pB+UOfTO3euTODElm2XbsIPoviCG85qSnFJADmiumKC5PyCJevSLy IHRDLrhtWsXJmsp2bWK97AAAyyVyh7c8E0SP9YC0pgesErBO9GmGePnKgOyrf4wFSut9jAqO8rn KRJb7nB/64Cj4gNwI1ZsxqPe272W56CN41A95qigCtW8hPhZN7ixljviANNw+cpXQSQd5yhujZA DWgeWX+mgSEYE9Wh+dqIYJd6RWy5uZP2fCe6KN5k/UBMRS5y02vcUsNSucF6+0KNaUthpZRXlO0 s9etUTCMt89sr4vSYnzqtdk6K3D5YsO0Y2TtClyYBFPQk83KZya+aihbXOW3SWHR3UMXVTfBjRw Gna/of9p9XJzLyAvRnNOqcPQtxEkZa2fDgkC7TqxGni2tG1ULc/0fZ/I9pAeezOmtL6T5qEER8g == X-Google-Smtp-Source: AGHT+IGIvTWVj2P/7XIHmNkAV3Zuukq0q/OPVkyOHkHLW/63pwLaZLQx4P6CvcJZq0ImF/R8zQy05A== X-Received: by 2002:a17:903:1ac8:b0:26f:f489:bba6 with SMTP id d9443c01a7336-290272f5913mr3577945ad.50.1759852817107; Tue, 07 Oct 2025 09:00:17 -0700 (PDT) Received: from name2965-Precision-7820-Tower.. ([121.185.186.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d125ed2sm169568165ad.35.2025.10.07.09.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 09:00:16 -0700 (PDT) From: Jeongjun Park To: stable@vger.kernel.org Cc: Takashi Iwai , syzbot+d8f72178ab6783a7daea@syzkaller.appspotmail.com, Clemens Ladisch , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Jeongjun Park Subject: [PATCH 6.12.y 6.6.y 6.1.y 5.15.y 5.10.y 5.4.y] ALSA: usb-audio: Kill timer properly at removal Date: Wed, 8 Oct 2025 00:58:08 +0900 Message-Id: <20251007155808.438441-1-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Takashi Iwai [ Upstream commit 0718a78f6a9f04b88d0dc9616cc216b31c5f3cf1 ] The USB-audio MIDI code initializes the timer, but in a rare case, the driver might be freed without the disconnect call. This leaves the timer in an active state while the assigned object is released via snd_usbmidi_free(), which ends up with a kernel warning when the debug configuration is enabled, as spotted by fuzzer. For avoiding the problem, put timer_shutdown_sync() at snd_usbmidi_free(), so that the timer can be killed properly. While we're at it, replace the existing timer_delete_sync() at the disconnect callback with timer_shutdown_sync(), too. Reported-by: syzbot+d8f72178ab6783a7daea@syzkaller.appspotmail.com Closes: https://lore.kernel.org/681c70d7.050a0220.a19a9.00c6.GAE@google.com Cc: Link: https://patch.msgid.link/20250519212031.14436-1-tiwai@suse.de Signed-off-by: Takashi Iwai [ del_timer vs timer_delete differences ] Signed-off-by: Jeongjun Park --- sound/usb/midi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/usb/midi.c b/sound/usb/midi.c index a792ada18863..c3de2b137435 100644 --- a/sound/usb/midi.c +++ b/sound/usb/midi.c @@ -1530,6 +1530,7 @@ static void snd_usbmidi_free(struct snd_usb_midi *umidi) snd_usbmidi_in_endpoint_delete(ep->in); } mutex_destroy(&umidi->mutex); + timer_shutdown_sync(&umidi->error_timer); kfree(umidi); } @@ -1553,7 +1554,7 @@ void snd_usbmidi_disconnect(struct list_head *p) spin_unlock_irq(&umidi->disc_lock); up_write(&umidi->disc_rwsem); - del_timer_sync(&umidi->error_timer); + timer_shutdown_sync(&umidi->error_timer); for (i = 0; i < MIDI_MAX_ENDPOINTS; ++i) { struct snd_usb_midi_endpoint *ep = &umidi->endpoints[i]; --