From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: broonie@kernel.org, tiwai@suse.de
Cc: linux-sound@vger.kernel.org, pierre-louis.bossart@linux.dev,
bard.liao@intel.com, niranjan.hy@ti.com,
sbinding@opensource.cirrus.com
Subject: [PATCH v2 1/9] ASoC: SOF: Don't print the monolithic topology name if function topology may be used
Date: Tue, 14 Oct 2025 15:13:27 +0800 [thread overview]
Message-ID: <20251014071335.3844631-2-yung-chuan.liao@linux.intel.com> (raw)
In-Reply-To: <20251014071335.3844631-1-yung-chuan.liao@linux.intel.com>
It may confuse people if "Topology file:" is printed but the topology
file is not really used. We keep the print if the topology file is
missing thus user can know what topology is missed in the file system.
And increase the log level to info for the actual topology that is used.
So that user can get which topology is used.
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Simon Trimmer <simont@opensource.cirrus.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
sound/soc/sof/fw-file-profile.c | 8 +++++++-
sound/soc/sof/topology.c | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sof/fw-file-profile.c b/sound/soc/sof/fw-file-profile.c
index 1c0eb13ae557..d2b232860091 100644
--- a/sound/soc/sof/fw-file-profile.c
+++ b/sound/soc/sof/fw-file-profile.c
@@ -266,6 +266,7 @@ static void sof_print_profile_info(struct snd_sof_dev *sdev,
enum sof_ipc_type ipc_type,
struct sof_loadable_file_profile *profile)
{
+ struct snd_sof_pdata *plat_data = sdev->pdata;
struct device *dev = sdev->dev;
if (ipc_type != profile->ipc_type)
@@ -282,7 +283,12 @@ static void sof_print_profile_info(struct snd_sof_dev *sdev,
if (profile->fw_lib_path)
dev_info(dev, " Firmware lib path: %s\n", profile->fw_lib_path);
- dev_info(dev, " Topology file: %s/%s\n", profile->tplg_path, profile->tplg_name);
+
+ if (plat_data->machine->get_function_tplg_files && !plat_data->disable_function_topology)
+ dev_info(dev, " Topology file: function topologies\n");
+ else
+ dev_info(dev, " Topology file: %s/%s\n",
+ profile->tplg_path, profile->tplg_name);
}
int sof_create_ipc_file_profile(struct snd_sof_dev *sdev,
diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index b6d5c8024f8c..3404f1306494 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -2525,7 +2525,7 @@ int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file)
if (!tplg_cnt) {
tplg_files[0] = file;
tplg_cnt = 1;
- dev_dbg(scomp->dev, "loading topology: %s\n", file);
+ dev_info(scomp->dev, "loading topology: %s\n", file);
} else {
dev_info(scomp->dev, "Using function topologies instead %s\n", file);
}
--
2.43.0
next prev parent reply other threads:[~2025-10-14 7:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 7:13 [PATCH v2 0/9] ASoC: use sof_sdw as default Intel SOF SDW machine driver Bard Liao
2025-10-14 7:13 ` Bard Liao [this message]
2025-10-14 7:13 ` [PATCH v2 2/9] ASoC: soc-acpi: make some variables of acpi adr and link adr non-const Bard Liao
2025-10-14 7:13 ` [PATCH v2 3/9] ASoC: soc_sdw_utils: add name_prefix to asoc_sdw_codec_info struct Bard Liao
2025-10-14 7:13 ` [PATCH v2 4/9] ASoC: Intel: export sof_sdw_get_tplg_files Bard Liao
2025-10-14 7:13 ` [PATCH v2 5/9] ASoC: soc_sdw_utils: export asoc_sdw_get_dai_type Bard Liao
2025-10-14 7:13 ` [PATCH v2 6/9] ASoC: SOF: add platform name into sof_intel_dsp_desc Bard Liao
2025-10-14 7:13 ` [PATCH v2 7/9] ASoC: SOF: don't check the existence of dummy topology Bard Liao
2025-10-14 7:13 ` [PATCH v2 8/9] ASoC: SOF: Intel: use sof_sdw as default SDW machine driver Bard Liao
2025-10-14 7:13 ` [PATCH v2 9/9] ASoC: sof-function-topology-lib: escalate the log when missing function topoplogy Bard Liao
2025-10-15 16:22 ` [PATCH v2 0/9] ASoC: use sof_sdw as default Intel SOF SDW machine driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014071335.3844631-2-yung-chuan.liao@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox