Re: [PATCH 02/27] ALSA: hda: Move HD-audio core stuff into sound/hda/core

Cezary Rojewski
2025-07-14T08:41:34Z

On 2025-07-09 6:04 PM, Takashi Iwai wrote:
> This is a part of HD-audio code restructuring.
> Simply move the current code of sound/hda/* into the subdirectory
> sound/hda/core, so that more stuff can be moved into sound/hda cleanly
> later.

Nitpicks: I'd suggest to drop 'stuff' in the title, 'HD-audio core' is
enough. Same with 'Simply move'. 'Move' is sufficient.

>
> Most of file names with hdac_ and hdac_ext_ prefix are renamed without
> the prefix, since they can be identified well in the directory name
> and superfluous.
>

Just nitpicks - nothing TODO as a must, looks good as is.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/hda/Kconfig | 67 +------------------
> sound/hda/Makefile | 22 +-----
> sound/hda/core/Kconfig | 67 +++++++++++++++++++
> sound/hda/core/Makefile | 22 ++++++
> sound/hda/{ => core}/array.c | 0
> sound/hda/{hdac_bus.c => core/bus.c} | 0
> .../{hdac_component.c => core/component.c} | 0
> .../{hdac_controller.c => core/controller.c} | 0
> sound/hda/{hdac_device.c => core/device.c} | 0
> sound/hda/{ => core}/ext/Makefile | 2 +-
> .../{ext/hdac_ext_bus.c => core/ext/bus.c} | 0
> .../ext/controller.c} | 0
> .../hdac_ext_stream.c => core/ext/stream.c} | 0
> sound/hda/{ => core}/hda_bus_type.c | 0
> sound/hda/{ => core}/hdmi_chmap.c | 0
> sound/hda/{hdac_i915.c => core/i915.c} | 0
> sound/hda/{ => core}/intel-dsp-config.c | 0
> sound/hda/{ => core}/intel-nhlt.c | 0
> sound/hda/{ => core}/intel-sdw-acpi.c | 0
> sound/hda/{ => core}/local.h | 0
> sound/hda/{hdac_regmap.c => core/regmap.c} | 0
> sound/hda/{hdac_stream.c => core/stream.c} | 0
> sound/hda/{hdac_sysfs.c => core/sysfs.c} | 0
> sound/hda/{ => core}/trace.c | 0
> sound/hda/{ => core}/trace.h | 0
> 25 files changed, 92 insertions(+), 88 deletions(-)
> create mode 100644 sound/hda/core/Kconfig
> create mode 100644 sound/hda/core/Makefile
> rename sound/hda/{ => core}/array.c (100%)
> rename sound/hda/{hdac_bus.c => core/bus.c} (100%)
> rename sound/hda/{hdac_component.c => core/component.c} (100%)
> rename sound/hda/{hdac_controller.c => core/controller.c} (100%)
> rename sound/hda/{hdac_device.c => core/device.c} (100%)
> rename sound/hda/{ => core}/ext/Makefile (54%)
> rename sound/hda/{ext/hdac_ext_bus.c => core/ext/bus.c} (100%)
> rename sound/hda/{ext/hdac_ext_controller.c => core/ext/controller.c} (100%)
> rename sound/hda/{ext/hdac_ext_stream.c => core/ext/stream.c} (100%)
> rename sound/hda/{ => core}/hda_bus_type.c (100%)
> rename sound/hda/{ => core}/hdmi_chmap.c (100%)
> rename sound/hda/{hdac_i915.c => core/i915.c} (100%)
> rename sound/hda/{ => core}/intel-dsp-config.c (100%)
> rename sound/hda/{ => core}/intel-nhlt.c (100%)
> rename sound/hda/{ => core}/intel-sdw-acpi.c (100%)
> rename sound/hda/{ => core}/local.h (100%)
> rename sound/hda/{hdac_regmap.c => core/regmap.c} (100%)
> rename sound/hda/{hdac_stream.c => core/stream.c} (100%)
> rename sound/hda/{hdac_sysfs.c => core/sysfs.c} (100%)
> rename sound/hda/{ => core}/trace.c (100%)
> rename sound/hda/{ => core}/trace.h (100%)