From: Sharique Mohammad <sharq0406@gmail.com>
To: linux-sound@vger.kernel.org
Cc: perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com,
Sharique Mohammad <sharq0406@gmail.com>
Subject: [PATCH 3/3] ASoC: max98090/91: added a comment for the users and fixed an extra space
Date: Wed, 15 Oct 2025 11:36:28 +0200 [thread overview]
Message-ID: <20251015093628.659936-3-sharq0406@gmail.com> (raw)
In-Reply-To: <20251015093628.659936-1-sharq0406@gmail.com>
added a comment that may be of help for the users of max98090/91 and
fixed and extra space.
Signed-off-by: Sharique Mohammad <sharq0406@gmail.com>
---
sound/soc/codecs/max98090.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index 0eeea6c1974d..386ef0caa6bf 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -1708,6 +1708,10 @@ static int max98090_dai_set_fmt(struct snd_soc_dai *codec_dai,
* for Bit Clock Invert (BCI). The inverted logic is only
* seen for the case of TDM mode. The remaining cases have
* normal logic.
+ *
+ * If one hears noise in audio, try commenting below code and
+ * then try again. Also, try playing around with register 0xC1
+ * record tdm slot.
*/
if (tdm_regval)
regval ^= M98090_BCI_MASK;
@@ -2414,7 +2418,7 @@ static struct snd_soc_dai_driver max98090_dai = {
.rates = MAX98090_RATES,
.formats = MAX98090_FORMATS,
},
- .ops = &max98090_dai_ops,
+ .ops = &max98090_dai_ops,
};
static int max98090_probe(struct snd_soc_component *component)
--
2.30.5
next prev parent reply other threads:[~2025-10-15 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 9:36 [PATCH 1/3] ASoC: max98090/91: added new ALSA routes and widgets Sharique Mohammad
2025-10-15 9:36 ` [PATCH 2/3] ASoC: max98090/91: fixed wrong channel constraint for .capture Sharique Mohammad
2025-10-15 9:36 ` Sharique Mohammad [this message]
2025-10-15 10:35 ` [PATCH 1/3] ASoC: max98090/91: added new ALSA routes and widgets Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015093628.659936-3-sharq0406@gmail.com \
--to=sharq0406@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox