Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Maciej Strozek <mstrozek@opensource.cirrus.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Maciej Strozek <mstrozek@opensource.cirrus.com>
Subject: [PATCH] ALSA: sound: Increase max size of components field
Date: Thu, 23 Oct 2025 10:27:41 +0100	[thread overview]
Message-ID: <20251023092754.84095-1-mstrozek@opensource.cirrus.com> (raw)

The components field of snd_card can run out of space in new systems which
use many audio devices, hence increase its size to 256 bytes.

Along with this change, bump the CTL protocol version to 2.0.10

Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
---
 include/sound/core.h        | 2 +-
 include/uapi/sound/asound.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/sound/core.h b/include/sound/core.h
index 64327e971122..0eb2e3ee0dd5 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -87,7 +87,7 @@ struct snd_card {
 	char longname[80];		/* name of this soundcard */
 	char irq_descr[32];		/* Interrupt description */
 	char mixername[80];		/* mixer name */
-	char components[128];		/* card components delimited with
+	char components[256];		/* card components delimited with
 								space */
 	struct module *module;		/* top-level module */

diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index 5a049eeaecce..c302698fb685 100644
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -1058,7 +1058,7 @@ struct snd_timer_tread {
  *                                                                          *
  ****************************************************************************/

-#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 9)
+#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 10)

 struct snd_ctl_card_info {
 	int card;			/* card number */
@@ -1069,7 +1069,7 @@ struct snd_ctl_card_info {
 	unsigned char longname[80];	/* name + info text about soundcard */
 	unsigned char reserved_[16];	/* reserved for future (was ID of mixer) */
 	unsigned char mixername[80];	/* visual mixer identification */
-	unsigned char components[128];	/* card components / fine identification, delimited with one space (AC97 etc..) */
+	unsigned char components[256];	/* card components / fine identification, delimited with one space (AC97 etc..) */
 };

 typedef int __bitwise snd_ctl_elem_type_t;
--
2.48.1


             reply	other threads:[~2025-10-23  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23  9:27 Maciej Strozek [this message]
2025-10-23 11:56 ` [PATCH] ALSA: sound: Increase max size of components field Jaroslav Kysela
2025-10-27  9:04   ` Takashi Iwai
2025-10-27 11:50     ` Maciej Strozek
2025-10-27 12:32       ` Richard Fitzgerald
2025-10-28  0:42       ` Takashi Sakamoto
2025-10-28 11:14         ` Maciej Strozek
2025-10-28 11:39       ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023092754.84095-1-mstrozek@opensource.cirrus.com \
    --to=mstrozek@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox