From: Andrew Morton <akpm@linux-foundation.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Junrui Luo <moonafterrain@outlook.com>,
linux-kernel@vger.kernel.org, pmladek@suse.com,
rostedt@goodmis.org, andriy.shevchenko@linux.intel.com,
tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
mchehab@kernel.org, awalls@md.metrocast.net,
linux-media@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] lib/sprintf: add scnprintf_append() helper function
Date: Fri, 7 Nov 2025 16:11:30 -0800 [thread overview]
Message-ID: <20251107161130.4418562992d2477c4accc6ef@linux-foundation.org> (raw)
In-Reply-To: <20251107091246.4e5900f4@pumpkin>
On Fri, 7 Nov 2025 09:12:46 +0000 David Laight <david.laight.linux@gmail.com> wrote:
> > I wonder if we should instead implement a kasprintf() version of this
> > which reallocs each time and then switch all the callers over to that.
>
> That adds the cost of a malloc, and I, like kasprintf() probably ends up
> doing all the work of snprintf twice.
There is no need at all to optimize the performance of scruffy once-off
string pasting functions. For these it's better to optimize for
readability, reliability. maintainability.
next prev parent reply other threads:[~2025-11-08 0:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251107051616.21606-1-moonafterrain@outlook.com>
2025-11-07 5:16 ` [PATCH 1/4] lib/sprintf: add scnprintf_append() helper function Junrui Luo
2025-11-07 5:38 ` Andrew Morton
2025-11-07 9:12 ` David Laight
2025-11-07 9:35 ` Andy Shevchenko
2025-11-07 12:52 ` Petr Mladek
2025-11-07 17:51 ` David Laight
2025-11-10 14:13 ` Petr Mladek
2025-11-11 13:31 ` Junrui Luo
2025-11-12 9:39 ` Petr Mladek
2025-11-08 0:11 ` Andrew Morton [this message]
2025-11-08 9:11 ` Takashi Iwai
2025-11-07 9:34 ` Andy Shevchenko
2025-11-07 5:16 ` [PATCH 2/4] ALSA: wavefront: use scnprintf_append for longname construction Junrui Luo
2025-11-07 5:16 ` [PATCH 3/4] media: ivtv: use scnprintf_append for i2c adapter name Junrui Luo
2025-11-07 5:16 ` [PATCH 4/4] net: qede: use scnprintf_append for version string Junrui Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107161130.4418562992d2477c4accc6ef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=awalls@md.metrocast.net \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=moonafterrain@outlook.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox