From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: [PATCH 0/4] ASoC: cs35l56: Set access permissions on volatile read-only controls
Date: Thu, 20 Nov 2025 13:44:33 +0000 [thread overview]
Message-ID: <20251120134437.1179191-1-rf@opensource.cirrus.com> (raw)
The CAL_SET_STATUS and CAL_DATA_RB controls are volatile and read-only, but
the existing ASoC macros to define controls don't allow setting access
permissions, so those controls were marked as non-volatile read/write.
These four patches fix that.
The first two patches add two new control macros to soc.h. I really don't
like codec drivers open-coding a kcontrol_new content for a control that
will be managed by the ASoC info/get/put handlers. If a new type of ASoC
control definition is needed it's better to have it in soc.h so all the
dependencies between ASoC and the kcontrol_new content are in one place.
Richard Fitzgerald (4):
ASoC: soc.h: Add SOC_ENUM_EXT_ACC() to allow setting access flags
ASoC: soc.h: Add SND_SOC_BYTES_E_ACC() to allow setting access flags
ASoC: cs35l56: Use SOC_ENUM_EXT_ACC() for CAL_SET_STATUS control
ASoC: cs35l56: Use SND_SOC_BYTES_E_ACC() for CAL_DATA_RB control
include/sound/soc.h | 14 ++++++++++++++
sound/soc/codecs/cs35l56.c | 15 +++++++++------
2 files changed, 23 insertions(+), 6 deletions(-)
--
2.47.3
next reply other threads:[~2025-11-20 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 13:44 Richard Fitzgerald [this message]
2025-11-20 13:44 ` [PATCH 1/4] ASoC: soc.h: Add SOC_ENUM_EXT_ACC() to allow setting access flags Richard Fitzgerald
2025-11-20 13:44 ` [PATCH 2/4] ASoC: soc.h: Add SND_SOC_BYTES_E_ACC() " Richard Fitzgerald
2025-11-20 13:44 ` [PATCH 3/4] ASoC: cs35l56: Use SOC_ENUM_EXT_ACC() for CAL_SET_STATUS control Richard Fitzgerald
2025-11-20 13:44 ` [PATCH 4/4] ASoC: cs35l56: Use SND_SOC_BYTES_E_ACC() for CAL_DATA_RB control Richard Fitzgerald
2025-11-21 22:11 ` [PATCH 0/4] ASoC: cs35l56: Set access permissions on volatile read-only controls Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120134437.1179191-1-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox