From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CCA2DFF1D for ; Mon, 24 Nov 2025 06:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763967036; cv=none; b=USjhSWHqO6EFC5KP7RQBiYkcUquZtvbFjByxoigCN8cOM2atsxBetoD5uffiMlSSmf53GXHsgVDZmi+FNVyDk2k1sOc4R8h6X6mzu0IC3e13/E+qWwd3MHHdSdbvCJrH3rgsT7jNv7nTX6mR+SGaK/ABP8Oc5OVhDoBFHYVGvzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763967036; c=relaxed/simple; bh=d6WN5H/+767vMaQcJjAjNCbjrtbpcRP4HbSZ+EaFPAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ubd7Be/E31Ev3LpBx05aXcXd4BOUzgVgKa4JY9yMNekNxBrSToemeBVEzedLmEdlpH1cIewO6k9Xuw5+Pg/pIKiDJPWTMsEQ0HMUAdHuowtoYZa/fOUa1RG6SrKlmVGh9jHs7t5awAsQdnHv7+QnWJ+iZg3R3wLEhhZ//d3ztJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=SMGIUgTR; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="SMGIUgTR" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8b22624bcdaso506575485a.3 for ; Sun, 23 Nov 2025 22:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1763967034; x=1764571834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0SbhPk+cIbagc0g7g2HIdLEmkXHw9QB9UvdhnuSgHsc=; b=SMGIUgTRRxYH5DGNp4MNCP7vjvOGwdhbRDTax/z21Rc0bgYIp225y7W9DQsxlVpquj t5MweCmOFXhL5GiyCpld9Dd/6qsfRWKhQCSVP+PyUlQzk+JrJI4LWzVi0B7TbiiVMP/a Yflp4xK/gz7axfTMW0F3t0syDQRPCY52LIhTuoOcvCy4ISmw9lXBhDwmdIJpZF7K4xmX isU+OTtwgbJxUuCJR7rPumSXVi/mnt+dc0+jXtlCpaXMCcDUWsd9aziXGkMaW6kmI/Zg 6XNFuMqFVt7obA0HD8fQKRRcDU5AMplniL70xqznhgoonifSEy9mQv4uEoBxqMEHrAjO cPWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763967034; x=1764571834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0SbhPk+cIbagc0g7g2HIdLEmkXHw9QB9UvdhnuSgHsc=; b=pm6TnZoQxnLNSO6IJagKQzIox2Ge5eCqJaNY5h61VVfwOGU6GAAAp0q1kg3MtRmiDu MvvKMWKfgQxjJSLMGgs6PSq/xc5f4iUvP/EPzeSX1SQvGmygy2GbjwRLovI/kB+lYPqz l5mMUWAF0ptPIKlQj4HmiWsA5cpbNHfSfA9iCpdpJuAtHSBoK/6QHhiVuHbvTpN9wgZw ttUPd2nU9egrQs8G+Sp4+gws64PKXJYd01bf9QLYD5QKxP7h1UuZ11ceAyxGkoEGeAOd xpOctxwfk/+4b4xYczXaRWzm3KpLn+73oW1hif+mUn5MULmhhXRuoUO3X89sy1/ltsSW wvLQ== X-Forwarded-Encrypted: i=1; AJvYcCWntHbfJPCHrHlCAPYlNCFzSY7R0NHOeNH4WgGtBSL4/cL/3L9NJZrl5Z47mDSYE2dZQhzrvsAuicri3Q==@vger.kernel.org X-Gm-Message-State: AOJu0YyiLQIWI2XCTyFdBo7kVSPxdtEi5wwE7wqawvsSWKkdXYRIioaB YDMarMGeHMuv7IIYy14L7VSZoQbsBCe6G8nYUiUNUl8zK0FshGWclboQpz2EAbHyo8U= X-Gm-Gg: ASbGncvl/UJF7Hq6r3e36M+P1Y2V8SpRqnSM6D3tgfORAQ2ur8UmC/5w7ylbrgK8gSf noPX0ePtS0OetPQEkPHOCcYu6zJEbrLwYr+hwSMcQrsNe0CHvD8s6lTPGl9GZHLmZBp2WrRWyeH JT5x3D9/g0t6yWxvlZZIyy4PPBdodBlkUNBMc6o/zqD95MlRJpO/X0FfxLtU6h0EOP6ZekgQjKI bCOnsVQq0gwc6EXjaJaNilsoe6V2tfuWo9FH8RyOWY0sCBjG07zLk5OGmeueHVS1DzWqtedqI3C EunJAMC2fKhQkT3vt+JM/BZucQvGpyV8wFftBz6++CX6bzH+m+lhBHn/KvUi67ECkKHEntJSwWK OBKGLNa0+IAw0Ckt0wPniIOQKAGGASJOWzH/WoPKT6S0Trc3q15To0VYp6rc98LluDVXukreDOd lVUClr58oybY5bXePm+dML4Lck9A9KBrbow6Xd4tR8TI+U4MKFKm0PRfxNF2Eoi7SwvA== X-Google-Smtp-Source: AGHT+IEBHwNCw3W+jfg9jESuLTfvci7rPCprytBblNB0K+hOqYvW2BCwSblqlDokDkAkj9jWN2s1ew== X-Received: by 2002:a05:620a:450c:b0:8b2:e922:529a with SMTP id af79cd13be357-8b33d1f93acmr1221802585a.19.1763967032817; Sun, 23 Nov 2025 22:50:32 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b3295db8b1sm889075185a.40.2025.11.23.22.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 22:50:31 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , Neil Armstrong , linux-sound@vger.kernel.org (open list:QCOM AUDIO (ASoC) DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/6] ASoC: codecs: wsa884x: remove mute_unmute_on_trigger Date: Mon, 24 Nov 2025 01:45:54 -0500 Message-ID: <20251124064850.15419-2-jonathan@marek.ca> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251124064850.15419-1-jonathan@marek.ca> References: <20251124064850.15419-1-jonathan@marek.ca> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit trigger is atomic (non-schedulable), and soundwire register writes are not safe to run in an atomic context. (bus is locked with a mutex, and qcom driver's callback can also sleep if the FIFO is full). The important part of fixing the click/pop issue was removing the PA_EN writes from the dapm events, AFAICT this flag doesn't help anyway. Fixes: 28b0b18d5346 ("ASoC: codec: wsa884x: make use of new mute_unmute_on_trigger flag") Signed-off-by: Jonathan Marek --- sound/soc/codecs/wsa884x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wsa884x.c b/sound/soc/codecs/wsa884x.c index 2484d4b8e2d94..0218dfc13bc77 100644 --- a/sound/soc/codecs/wsa884x.c +++ b/sound/soc/codecs/wsa884x.c @@ -1840,7 +1840,6 @@ static const struct snd_soc_dai_ops wsa884x_dai_ops = { .hw_free = wsa884x_hw_free, .mute_stream = wsa884x_mute_stream, .set_stream = wsa884x_set_stream, - .mute_unmute_on_trigger = true, }; static struct snd_soc_dai_driver wsa884x_dais[] = { -- 2.51.0