From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: tiwai@suse.com, perex@perex.cz, amade@asmblr.net,
linux-sound@vger.kernel.org, andriy.shevchenko@linux.intel.com,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v2 1/6] ASoC: Intel: catpt: Fix offset checks
Date: Wed, 26 Nov 2025 10:55:18 +0100 [thread overview]
Message-ID: <20251126095523.3925364-2-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20251126095523.3925364-1-cezary.rojewski@intel.com>
Verify if the entire block is found within DRAM, not just
the start of it.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/catpt/loader.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/intel/catpt/loader.c b/sound/soc/intel/catpt/loader.c
index 696d84314eeb..5804de1d89e3 100644
--- a/sound/soc/intel/catpt/loader.c
+++ b/sound/soc/intel/catpt/loader.c
@@ -216,7 +216,7 @@ static int catpt_restore_memdumps(struct catpt_dev *cdev, struct dma_chan *chan)
continue;
off = catpt_to_host_offset(info->offset);
- if (off < cdev->dram.start || off > cdev->dram.end)
+ if (off < cdev->dram.start || off + info->size >= cdev->dram.end)
continue;
dev_dbg(cdev->dev, "restoring memdump: off 0x%08x size %d\n",
@@ -261,12 +261,12 @@ static int catpt_restore_fwimage(struct catpt_dev *cdev,
continue;
off = catpt_to_host_offset(info->offset);
- if (off < cdev->dram.start || off > cdev->dram.end)
- continue;
-
r2.start = off;
r2.end = r2.start + info->size - 1;
+ if (r2.start < cdev->dram.start || r2.end > cdev->dram.end)
+ continue;
+
if (!resource_intersection(&r2, &r1, &common))
continue;
/* calculate start offset of common data area */
--
2.25.1
next prev parent reply other threads:[~2025-11-26 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 9:55 [PATCH v2 0/6] ASoC: Intel: catpt: Round of fixes and PM changes Cezary Rojewski
2025-11-26 9:55 ` Cezary Rojewski [this message]
2025-11-26 18:09 ` [PATCH v2 1/6] ASoC: Intel: catpt: Fix offset checks Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 2/6] ASoC: Intel: catpt: Switch to resource_xxx() API Cezary Rojewski
2025-11-26 15:41 ` Andy Shevchenko
2025-11-26 18:08 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 3/6] ASoC: Intel: catpt: Fix error path in hw_params() Cezary Rojewski
2025-11-26 16:22 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 4/6] ASoC: Intel: catpt: Fix probing order of driver components Cezary Rojewski
2025-11-26 16:22 ` Andy Shevchenko
2025-11-26 9:55 ` [PATCH v2 5/6] ASoC: Intel: catpt: Do not ignore errors on runtime resume Cezary Rojewski
2025-11-26 9:55 ` [PATCH v2 6/6] ASoC: Intel: catpt: Do not block the system from suspending Cezary Rojewski
2025-11-28 18:01 ` [PATCH v2 0/6] ASoC: Intel: catpt: Round of fixes and PM changes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251126095523.3925364-2-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amade@asmblr.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox