Re: [PATCH] ALSA: dice: fix buffer overflow in detect_stream_formats()

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

Hi,

On Fri, Nov 28, 2025 at 12:06:31PM +0800, Junrui Luo wrote:
> The function detect_stream_formats() reads the stream_count value directly
> from a FireWire device without validating it. This can lead to
> out-of-bounds writes when a malicious device provides a stream_count value
> greater than MAX_STREAMS.
> 
> Fix by applying the same validation to both TX and RX stream counts in
> detect_stream_formats().
> 
> Reported-by: Yuhao Jiang <danisjiang@gmail.com>
> Reported-by: Junrui Luo <moonafterrain@outlook.com>
> Fixes: 58579c056c1c ("ALSA: dice: use extended protocol to detect available stream formats")
> Cc: stable@vger.kernel.org
> Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
> ---
>  sound/firewire/dice/dice-extension.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
 
Looks good to me.

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Regards

Takashi Sakamoto